Bug fixes and refactors #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Stop the layout from jumping on the Dashboard page while we are conditionally rendering in
blog-project/client/src/App.tsxwhile waiting for the user to be available (solution was to display<Loader/>until the user is loaded).Also, refactored the ternary logic into a separate component which is more and 'React-like'
Fix issue with blog posts not displaying on Dashboard (added check for author.email in
blog-project/client/src/components/BlogpostDetails.tsxcomponent)Remove unnecessary fetch from
blog-project/client/src/components/BlogpostDetails.tsx- the parent component is already providing a blogpost as a propDeleted some comments and unused code from Dashboard
Enabled Dashboard to read all blog posts from Context instead of fetching them again - and just filter them for the the user.
Refactored some actions in the blog post reducer - we don't need a GET and SET for blogposts- reducers have a single responsibility and that is to handle state updates - we are only ever SETTING here, not GETTING :)