Add the ability to localize the application #246
Conversation
If the artwork data cannot be found, it will be replaced with a placeholder provided by media player
…e app icon as a placeholder
…e is this is sometimes 0 even though something is playing
…p button is pressed or the source modifies the elapsedTime after being paused
…edDisplay so that boringNotch remembers the last manually selected screen and tries to use it if it is available
…ated onChange calls
…el to BoringView Coordinator. This will help isolate the singleton-required code from the ViewModel that is now specific to each window.
… add new show on all displays beta option
…creens (seperate control from non-notched displays)
grumlu
changed the title
|
I have updated all the strings to use a key instead of the English translation. The French translation has also been updated to match this change and fix some display issues. |
All elements inside the notch are now animated with an elegant blur effect that tries to imitate Apple's implementation as much as possible.
I built it lol |
It seems to be an authentication / pipeline issue for Cori, right? Or did I do something wrong? |
|
Yes action was for that only. |
theboringhumane
force-pushed
the
feature/localization
branch
from
cfa1263 to
3d55c90
Compare
|
The app is already localizable, no need to change texts, Xcode handles it. |
One commit earlier does the translation in French without changing all the texts. |
|
@richardkunkli why don't you create a string database on Crowdin or Lokalise to enable localisation without having to start from source and use Xcode? |
|
@piersandro I have set up everything (including Crowdin) months ago, but haven't published yet, due to the extensive changes in the settings that includes the most strings. I believe soon we can launch it. |
|
Thank you @richardkunkli. Excellent news. I'll be ready for the Italian localisation 👍 |
|
@theboringhumane / @richardkunkli , is it worth that I update my work to match with the Jellyfin update or shall I close the PR? |
|
Will check the PR more deeply next week. Currently so busy, I have no time to work on these side projects. Maybe worth to ping me again with this if it's not a problem you. |
|
Close this PR probably since, @richardkunkli already setted up Crowdin |
|
I prepared the German translation for myself today and just wanted to make it available here. But I just realized that this is not possible at all? Maybe someone can help me? |
|
I’ve created a Crowdin project for localization: https://crowdin.com/project/boring-notch |
9 participants
Following a feature request on Discord, to add Chinese language to the app, I looked into how to support different languages.
I have added a localization for French as well.
Changes are in
For now there is apparently no conflicting keys, however in the future it may be interesting to refactor the code to add "backend" names to each string depending on where they're used.