Dev #453

theboringhumane · 2025-03-26T16:12:13Z

No description provided.

- Add `openBatterySettings` function in `BatteryMenuView` to open battery settings in System Preferences ⚙️ - Improve `powerSourceText` to handle various battery states including fully charged, charging, and low power mode 🔋 - Refactor code to reduce nested `if` statements and improve readability 🧹 - Ensure text color adapts to light and dark modes 🌗 - Adjust icons for bolt and power plug to ensure proper alignment ⚡🔌 These improvements provide more detailed information about the battery status, beyond just displaying an icon 📊

- Changed `percentage`, `isCharging`, `isInLowPowerMode`, and `isInitialPlugIn` to regular properties in `BatteryView` - Updated `BatteryMenuView` and `BoringBatteryView` to pass these properties correctly - Improved code readability and performance by avoiding unnecessary state management: simplifies the data flow from parent to child views. - Added detailed documentation to explain the purpose of each property and method

- Changed `percentage`, `isCharging`, `isInLowPowerMode`, and `isInitialPlugIn` to regular properties in `BatteryView` - Updated `BatteryMenuView` and `BoringBatteryView` to pass these properties correctly - Improved code readability and performance by avoiding unnecessary state management: simplifies the data flow from parent to child views

🔧 Settings: - Add battery indicator visibility toggle - Add battery notifications toggle - Add battery percentage display option - Add battery status icon toggle 🏗️ Code Changes: - Implement BatteryInfo struct for better organization - Add PowerState enum for status handling - Improve status text formatting - Refactor battery monitoring logic 📚 Documentation: - Document battery-related methods - Add clear method descriptions - Document new settings options ♻️ Refactor: - Improve battery status updates - Better power state handling - Clean code organization with MARK comments

This update improves the battery status visualization with the following changes: ## 🔄 Battery Activity Manager - ✅ Added robust error handling with specific error types - 📊 Implemented consistent battery status monitoring - ⚡️ Optimized notification queue for better performance - 📝 Added comprehensive documentation throughout the module - 🛡️ Created a more reliable battery data retrieval system ## 🎨 Battery UI Components - ➕ Added a detailed `BatteryMenuView` component that shows: - 📊 Battery percentage and max capacity - ⚡️ Charging status with visual indicators - 🔋 Low power mode status - ⏱️ Time to full charge (when applicable) - ⚙️ Direct access to system battery preferences - 💪 Enhanced `BoringBatteryView` with: - 👆 Interactive popover menu triggered by press gestures - ✨ Animation feedback on interaction - 🔢 Optional battery percentage display (toggleable via preferences) - 🎭 Improved visual styling for different battery states - 🔍 Refined `BatteryView` component with: - 🚦 Better visual indicators for charging, plugged-in, and low power states - 📱 Responsive layout that adapts to different sizes - 🔄 Consistent styling across notification and main UI contexts ## 🧩 Code Quality - 🏗️ Improved code organization with better separation of concerns - 🛡️ Enhanced type safety with generics and proper error handling - 📚 Added comprehensive documentation for all public methods - 🚀 Optimized performance for battery status monitoring and updates These improvements provide users with more detailed battery information and better interaction options while maintaining a clean interface, ensuring consistent performance across different system conditions. 🌟

This reverts commit af62680.

This update improves the battery status visualization with the following changes: ## 🔄 Battery Activity Manager - ✅ Added robust error handling with specific error types - 📊 Implemented consistent battery status monitoring - ⚡️ Optimized notification queue for better performance - 📝 Added comprehensive documentation throughout the module - 🛡️ Created a more reliable battery data retrieval system ## 🎨 Battery UI Components - ➕ Added a detailed `BatteryMenuView` component that shows: - 📊 Battery percentage and max capacity - ⚡️ Charging status with visual indicators - 🔋 Low power mode status - ⏱️ Time to full charge (when applicable) - ⚙️ Direct access to system battery preferences - 💪 Enhanced `BoringBatteryView` with: - 👆 Interactive popover menu triggered by press gestures - ✨ Animation feedback on interaction - 🔢 Optional battery percentage display (toggleable via preferences) - 🎭 Improved visual styling for different battery states - 🔍 Refined `BatteryView` component with: - 🚦 Better visual indicators for charging, plugged-in, and low power states - 📱 Responsive layout that adapts to different sizes - 🔄 Consistent styling across notification and main UI contexts ## 🧩 Code Quality - 🏗️ Improved code organization with better separation of concerns - 🛡️ Enhanced type safety with generics and proper error handling - 📚 Added comprehensive documentation for all public methods - 🚀 Optimized performance for battery status monitoring and updates These improvements provide users with more detailed battery information and better interaction options while maintaining a clean interface, ensuring consistent performance across different system conditions. 🌟

- Adjust `BatteryMenuView` to display "charging on hold" status when applicable. - Update images for plug and bolt, add new assets, and adjust icons to match macOS design.

Delete the Sidebar icon folder as it is no longer needed.

- Modified condition to display battery percentage when it is equal to or greater than 80%

Ensure ci/cd uses latest version of setup-xcode to resolve errors

…d safety - Enhanced deinit method with semaphore to ensure safe session stopping - Improved session setup and teardown with more robust thread management - Added main thread dispatching for preview layer operations - Simplified session start and stop methods with better error handling - Removed redundant state updates and improved device connection handling

- Changed `checkCameraAvailability()` from private to public access - Removed automatic session start and state update from setup method - Provides more flexibility for external control of camera session lifecycle

… fullscreen detection

…mView and WebcamManager

…alization

Fixes to Fullscreen Detection, Playback Management, Elapsed Time Calculations, and Webcam Management

cori-ai · 2025-04-22T06:15:45Z

boringNotch/models/PlaybackState.swift

+struct PlaybackState {
+    var bundleIdentifier: String
+    var isPlaying: Bool = false
+    var title: String = "I'm Handsome"


🎨 Consider using a more descriptive title instead of "I'm Handsome" for better clarity in the context of playback. For example:

var title: String = "Unknown Title"

cori-ai · 2025-04-22T06:15:47Z

boringNotch/models/PlaybackState.swift

+    var currentTime: Double = 0
+    var duration: Double = 0
+    var playbackRate: Double = 1
+    var isShuffled: Bool? = nil


🔍 The optional properties isShuffled and isRepeating could be initialized to false instead of nil for better clarity on their default state:

var isShuffled: Bool = false var isRepeating: Bool = false

cori-ai · 2025-04-22T06:15:49Z

boringNotch/models/PlaybackState.swift

+    var playbackRate: Double = 1
+    var isShuffled: Bool? = nil
+    var isRepeating: Bool? = nil
+    var lastUpdated: Date = Date.distantPast


🕒 Consider using Date() instead of Date.distantPast for lastUpdated to reflect the current time when a new PlaybackState is created:

var lastUpdated: Date = Date()

cori-ai · 2025-04-22T06:15:50Z

boringNotch/observers/FullscreenMediaDetection.swift

 import SwiftUI

 class FullscreenMediaDetector: ObservableObject {
+    static let shared = FullscreenMediaDetector()


🔍 Consider adding a comment explaining the purpose of the shared instance for clarity. This helps other developers understand its usage.

static let shared = FullscreenMediaDetector()

cori-ai · 2025-04-22T06:15:52Z

boringNotch/observers/FullscreenMediaDetection.swift

 class FullscreenMediaDetector: ObservableObject {
+    static let shared = FullscreenMediaDetector()
    let detector: MacroVisionKit
+    let musicManager: MusicManager


🛠️ Ensure that MusicManager.shared is thread-safe if accessed from multiple threads. Consider using a dispatch queue or other synchronization mechanisms if necessary.

let musicManager: MusicManager

cori-ai · 2025-04-22T06:15:54Z

boringNotch/observers/FullscreenMediaDetection.swift

-    var nowPlaying: NowPlaying = .init()
-
-    init() {
+    private init() {


🔒 The init method is private, which is good for singleton patterns. Ensure that this is documented to clarify its intended use.

private init() {

cori-ai · 2025-04-22T06:15:56Z

boringNotch/observers/FullscreenMediaDetection.swift

        DispatchQueue.main.async {
            if let frontmostApp = NSWorkspace.shared.frontmostApplication {
-                let sameAsNowPlaying = !Defaults[.alwaysHideInFullscreen] ? frontmostApp.bundleIdentifier == self.nowPlaying.appBundleIdentifier : true
+                let sameAsNowPlaying = !Defaults[.alwaysHideInFullscreen] ? frontmostApp.bundleIdentifier == self.musicManager.bundleIdentifier : true


🔄 The change from self.nowPlaying.appBundleIdentifier to self.musicManager.bundleIdentifier is appropriate. Ensure that musicManager is initialized before this method is called to avoid potential nil issues.

let sameAsNowPlaying = !Defaults[.alwaysHideInFullscreen] ? frontmostApp.bundleIdentifier == self.musicManager.bundleIdentifier : true

cori-ai · 2025-04-22T06:15:58Z

boringNotch/private/CGSSpace.swift

 //  Created by Alexander Greco on 2024-10-27.
 //

+import AppKit


🔧 Consider adding a comment explaining why AppKit is imported here, especially if it's not immediately clear how it's used in the class. This helps maintain clarity for future developers. 📝

cori-ai · 2025-04-22T06:15:59Z

boringNotch/sizing/matters.swift

-
        // Check if the Mac has a notch
        if screen.safeAreaInsets.top > 0 {
+            // This is a display WITH a notch - use notch height settings


🔍 This comment is clear and relevant, indicating that the following logic applies to displays with a notch. Keep it! ✅

cori-ai · 2025-04-22T06:16:01Z

boringNotch/sizing/matters.swift

                notchHeight = screen.frame.maxY - screen.visibleFrame.maxY
            }
+        } else {
+            // This is a display WITHOUT a notch - use non-notch height settings


🔍 This comment effectively clarifies that the following logic applies to displays without a notch. Keep it! ✅

…opening app on init of media controller and update packages

…k per-display

… in fullscreen on non-notch displays

Fullscreen fixes

Fix popover hover

…ch the physical notch size

Use more rounded corners and reduce closed notch width

…for a license change

Add a new calendar service

Update LICENSE

AlexLemus-Dev and others added 14 commits March 26, 2025 21:34

Revert "🔋 Battery Component Enhancements"

286fee9

This reverts commit af62680.

Remove Develop Team

b8d41cb

Update the text for the charging status

e43b941

Update the text for the charging status

0214a38

Add detection for "charging on hold" and update battery view ⚡🔋

3827345

- Adjust `BatteryMenuView` to display "charging on hold" status when applicable. - Update images for plug and bolt, add new assets, and adjust icons to match macOS design.

Remove unnecessary Sidebar icon folder 📁🗑️

52229bb

Delete the Sidebar icon folder as it is no longer needed.

🔋 Adjust battery percentage display

1cda862

- Modified condition to display battery percentage when it is equal to or greater than 80%

Update cicd.yml

0130c04

Ensure ci/cd uses latest version of setup-xcode to resolve errors

cori-ai bot added the cori-ai-review Cori AI review label Mar 26, 2025

Merge branch 'main' into dev

4e864ec

theboringhumane temporarily deployed to github-pages March 26, 2025 16:12 — with GitHub Actions Inactive

theboringhumane and others added 6 commits March 26, 2025 13:05

🔧 refactor(WebcamManager): Expose camera availability check method

1702468

- Changed `checkCameraAvailability()` from private to public access - Removed automatic session start and state update from setup method - Provides more flexibility for external control of camera session lifecycle

Improve slider elapsed time calculation, playback control manager and…

d10dd4f

… fullscreen detection

Enhance camera authorization handling and session management in Webca…

6006006

…mView and WebcamManager

Final touches to move all MediaRemote code into MusicManager fix inti…

09f091c

…alization

Merge pull request #449 from Alexander5015/various-fixes

7e6b560

Fixes to Fullscreen Detection, Playback Management, Elapsed Time Calculations, and Webcam Management

Alexander5015 temporarily deployed to github-pages March 26, 2025 17:12 — with GitHub Actions Inactive

Allow 0 height notch

e2eb2ae

theboringhumane temporarily deployed to github-pages March 26, 2025 17:20 — with GitHub Actions Inactive

MioShirakawa added 2 commits March 26, 2025 22:51

improve haptic behavior

3b45cad

improve wheel picker snapping

0734fba

theboringhumane temporarily deployed to github-pages March 26, 2025 17:21 — with GitHub Actions Inactive

Readded sneakpeek and fixed jiggle

b9a441a

cori-ai bot reviewed Apr 22, 2025

View reviewed changes

Alexander5015 added 5 commits May 12, 2025 16:57

Update AppleScript updates to run off the main UI thread and prevent …

f151bb8

…opening app on init of media controller and update packages

Update fullscreen detection to utilize the new MacroVisionKit and wor…

0da25e1

…k per-display

Update extended hover area and add hover zone for zero height notch

aa7eef9

Add effectiveClosedNotchHeight to make the notch hide completely when…

ac307fe

… in fullscreen on non-notch displays

Merge pull request #546 from Alexander5015/fullscreen-fixes

b001d00

Fullscreen fixes

Alexander5015 temporarily deployed to github-pages May 13, 2025 01:07 — with GitHub Actions Inactive

Alexander5015 added 3 commits May 13, 2025 10:36

Track popover hover state to properly manage when to close notch

4c9c830

disable extended hover for now

92e9016

Merge pull request #547 from Alexander5015/fix-popover-hover

0faee67

Fix popover hover

Alexander5015 temporarily deployed to github-pages May 14, 2025 00:35 — with GitHub Actions Inactive

Alexander5015 added 2 commits May 18, 2025 14:37

Use more rounded corners, and reduce closed notch width to better mat…

c727695

…ch the physical notch size

Merge pull request #553 from Alexander5015/fix-notch-shape

93fafca

Use more rounded corners and reduce closed notch width

Alexander5015 temporarily deployed to github-pages May 18, 2025 19:22 — with GitHub Actions Inactive

Alexander5015 added 2 commits June 14, 2025 10:15

Add a new Calendar services to remove old contributed code, allowing …

2fcad4f

…for a license change

Merge pull request #589 from Alexander5015/new-calendar-service

5c624dc

Add a new calendar service

Alexander5015 temporarily deployed to github-pages June 14, 2025 14:37 — with GitHub Actions Inactive

Alexander5015 added 2 commits June 14, 2025 10:45

Update LICENSE

cb9cb58

Merge pull request #590 from Alexander5015/license-change

1e95f11

Update LICENSE

Alexander5015 temporarily deployed to github-pages June 14, 2025 14:49 — with GitHub Actions Inactive

Alexander5015 closed this Jun 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Dev #453

Dev #453

Uh oh!

theboringhumane commented Mar 26, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Dev #453

Dev #453

Uh oh!

Conversation

theboringhumane commented Mar 26, 2025

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

cori-ai bot Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants