task complete #14
Open
task complete #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| **************************************************************/ | ||
| function findFirstStringStartingWithLetter(letter, strings) { | ||
| //TODO: Add your code here | ||
| strings = strings.map((value, index, array) => { |
There was a problem hiding this comment.
You didn't have to loop over every string in the array to make them lower cased, instead you could've just done that inside the find method like so:
strings.find( (value)=> value.toLowerCase().startsWith(letter))
| strings = strings.map((value, index, array) => { | ||
| return value.toLowerCase(); | ||
| }); | ||
| console.log(strings.filter((value) => value.startsWith(letter))); |
There was a problem hiding this comment.
You're supposed to find only one item using the find method, hence the name of the function findFirst...
| function searchReviewers(query, reviewers) { | ||
| //TODO: ADD YOUR CODE HERE | ||
| query = query.toLowerCase(); | ||
| reviewers.map((element) => { |
There was a problem hiding this comment.
You didn't have to loop over the array twice to make the reviewerName & description lower cased, you could've done so directly inside the filter method, since you have the value there and you can just attach .toLowerCase to each value there.
i.e:
if (
value.reviewerName.toLowerCase().includes(query) &&
value.description.toLowerCase().includes(query)
) {
return value;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.