DeliveryModule wasn't correctly retrieved.#1
Merged
TheCoreDev31 merged 1 commit intomasterfrom Dec 11, 2019
Merged
Conversation
Previously, the function was getting the first encountered module, event if it wasn't a delivery module. Therefore, postage data retrieved later (line 414) returned an error. Now, we get the right delivery module (from the order object).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the function was getting the first active module, even if it wasn't a delivery module.
Therefore, postage data retrieving (occurring line 414) was returning a "Cannot commit because a nested transaction was rolled back" error.
Now, we get the right delivery module, directly from the order.