#163038007 Adjust UI features and api logic#24
Closed
TheDrizzyWay wants to merge 1 commit intodevelopfrom
Closed
Conversation
Oluwafayokemi
requested changes
Jan 8, 2019
Collaborator
Oluwafayokemi
left a comment
There was a problem hiding this comment.
- In meetupController .js instead of variable mLength, please make your variable name more descriptive
- obj is not descriptive enough
- aDate should now be oldDate and bDate should now be newDate
in questionController, also look at qLength, you can make it questionLength, as well as obj can be replaced with something more descriptive
- For your validations, can we use a Library such as validate.js, express validator, etc. to achieve a better result?
Note: Make all your variable names very descriptive
| @@ -8,13 +7,12 @@ export default { | |||
|
|
|||
| if (!meetup) return res.status(404).send({ status: 404, error: 'Meetup does not exist.' }); | |||
Collaborator
There was a problem hiding this comment.
In place of res.send, can you use res.json? Find out the difference and implement
Owner
Author
There was a problem hiding this comment.
I have implemented the aforementioned changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes some front-end features and refactors some of the logic in the application api.
Description of Task to be completed?
Pending Tasks
How should this be manually tested?
ft-feedback-163038007What are the relevant pivotal tracker stories?
163038007