Skip to content

#163038007 Adjust UI features and api logic#24

Closed
TheDrizzyWay wants to merge 1 commit intodevelopfrom
ft-feedback-163038007
Closed

#163038007 Adjust UI features and api logic#24
TheDrizzyWay wants to merge 1 commit intodevelopfrom
ft-feedback-163038007

Conversation

@TheDrizzyWay
Copy link
Owner

What does this PR do?

This PR fixes some front-end features and refactors some of the logic in the application api.

Description of Task to be completed?

  • Change the UI colour scheme
  • Re-position the login form and remove unnecessary navigation buttons
  • Increase the width of form inputs and amount of font spacing
  • Change the create post button
  • Change location images in the meetup view page
  • Remove unneeded classes and routes from the api
  • Convert dates to a more readable format
  • Adjust arguments in date sorting function in the api

Pending Tasks

  • Change colour scheme on user profile and comments page
  • Use validation library for sanitizing input

How should this be manually tested?

  • Clone the repo
  • Checkout to the branch ft-feedback-163038007
  • run npm install

What are the relevant pivotal tracker stories?

163038007

Copy link
Collaborator

@Oluwafayokemi Oluwafayokemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In meetupController .js instead of variable mLength, please make your variable name more descriptive
  • obj is not descriptive enough
  • aDate should now be oldDate and bDate should now be newDate

in questionController, also look at qLength, you can make it questionLength, as well as obj can be replaced with something more descriptive

  • For your validations, can we use a Library such as validate.js, express validator, etc. to achieve a better result?
    Note: Make all your variable names very descriptive

@@ -8,13 +7,12 @@ export default {

if (!meetup) return res.status(404).send({ status: 404, error: 'Meetup does not exist.' });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In place of res.send, can you use res.json? Find out the difference and implement

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have implemented the aforementioned changes

@TheDrizzyWay TheDrizzyWay deleted the ft-feedback-163038007 branch January 8, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants