Adding generation parameter to gather to enable using it more than once#2003
Merged
Conversation
- also: adding gather_here and gather_there accept plain values (instead of futures) - flyby: change size_t = ~0U to size_t = size_t(-1) This fixes #2001
Contributor
Author
|
@ltroska This fixes the issue you reported in #2001. Please verify. Note however, that the API of |
| std::size_t num_sites = ~0U, std::size_t this_site = ~0U); | ||
|
|
||
| std::size_t num_sites = std::size_t(-1), | ||
| std::size_t generation = std::size_t(-1), |
Contributor
There was a problem hiding this comment.
Can't we have the generation as the last parameter?
Contributor
Author
There was a problem hiding this comment.
I thought about this. I assumed that a user would want to specify an invocation site less frequently as this defaults to the current locality. Thus I moved that one to the end.
Contributor
There was a problem hiding this comment.
Indeed, the issue is fixed for me. Thank you!
hkaiser
added a commit
that referenced
this pull request
Feb 25, 2016
Adding generation parameter to gather to enable using it more than once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2001