Suppress or fix clang-tidy-9 warnings

[msimberg]

Attempting to fix new warnings after updating from 8 to 9.

[biddisco]

LGTM

[hkaiser]

I think with this change all of the static_cast's can go away now as well.

[msimberg]

Btw, I've suppressed quite a few warnings that to me look like false positives. If you see something that actually seems like a bug please let me know and I'll try to fix it.

[msimberg]

Related to the docker image upgrade, the python command isn't available anymore (only python3). We have a few Python scripts which explicitly use /usr/bin/env python which now fail on CircleCI. We can:

• change python to python3,
• symlink python to python3 in the docker image, or
• generate the shebang line in those scripts like we do for scripts that get installed.

My preference is in the order they're listed. Opinions?

[hkaiser]

Since python V2 is being phased out everywhere, I think we are safe to rename the command to python3. I don't know however if this would be correct on all platforms. Option 3 might be the safest way forward.

[msimberg]

Since python V2 is being phased out everywhere, I think we are safe to rename the command to python3. I don't know however if this would be correct on all platforms. Option 3 might be the safest way forward.

That's my thinking as well. I see that we actually install many of the Python scripts. I'll generate them with the Python that we find during configuration. Scripts that aren't installed I'll leave with python3.

This is finally passing clang-tidy now. The spell checker is complaining about some changes that I missed earlier. I'll leave those out of this PR and look at them separately (or try to ignore them if possible).

[msimberg]

I unfortunately don't have the time to update the scripts now until Monday. If someone wants to push to this branch feel free to do so so that we can get builds working for everyone, or we just merge it like this and I change the python shebangs separately next week.