modified existing extrema algo tests#6724
modified existing extrema algo tests#6724sleepingeight wants to merge 1 commit intoTheHPXProject:masterfrom
Conversation
Signed-off-by: Surya Teja <theallrounder.mst@gmail.com>
4d9bc25 to
c88e3ec
Compare
|
Can one of the admins verify this patch? |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
I wouldn't like removing the tests realted to sentinels. |
…extrema algorithms - Added random_repeat utility for duplicate testing - Updated extrema algorithm tests to use random_repeat - Fixed sentinel test failures by injecting unique values - Supersedes TheHPXProject#6684 and TheHPXProject#6724 Signed-off-by: Dhyann Olemmyan <olemmyandhyan@gmail.com>
…extrema algorithms - Added random_repeat utility for duplicate testing - Updated extrema algorithm tests to use random_repeat - Fixed sentinel test failures by injecting unique values - Supersedes TheHPXProject#6684 and TheHPXProject#6724 Signed-off-by: Dhyann Olemmyan <olemmyandhyan@gmail.com>
…extrema algorithms - Added random_repeat utility for duplicate testing - Updated extrema algorithm tests to use random_repeat - Fixed sentinel test failures by injecting unique values - Supersedes TheHPXProject#6684 and TheHPXProject#6724 Signed-off-by: Dhyann Olemmyan <olemmyandhyan@gmail.com>
|
closing this since a PR solving this issue has already been merged. |
…extrema algorithms - Added random_repeat utility for duplicate testing - Updated extrema algorithm tests to use random_repeat - Fixed sentinel test failures by injecting unique values - Supersedes TheHPXProject#6684 and TheHPXProject#6724 Signed-off-by: Dhyann Olemmyan <olemmyandhyan@gmail.com>
Fixes #6627
Proposed Changes
random_repeatto generate vectors having repeated values.Any background context you want to provide?
Used
uniform_int_distributionto generate random numbers.Tests for container_algorithms can also be modified, but the tests need to be modified to not use
sentinel(as we have duplicate values in our vector). I can update the tests if usage ofsentinelcan be removed in these tests.Checklist
Not all points below apply to all pull requests.