Skip to content

tracing: add hpx::tracing::rename_region abstraction#7263

Merged
hkaiser merged 2 commits into
TheHPXProject:masterfrom
v4xsh:tracing-add-rename-region
May 13, 2026
Merged

tracing: add hpx::tracing::rename_region abstraction#7263
hkaiser merged 2 commits into
TheHPXProject:masterfrom
v4xsh:tracing-add-rename-region

Conversation

@v4xsh
Copy link
Copy Markdown
Contributor

@v4xsh v4xsh commented May 12, 2026

Proposed Changes

  • Add hpx::tracing::rename_region free function to the unified tracing abstraction layer in libs/core/tracing
  • Implement Tracy backend by delegating to hpx::tracy::detail::rename_region; ITT and no-op branches are inline no-ops in the header since ITTNotify has no rename equivalent
  • Replace the raw #if defined(HPX_HAVE_MODULE_TRACY) / tracy::detail::rename_region / #endif block in thread_data.cpp with a clean backend-agnostic hpx::tracing::rename_region(...) call

Any background context you want to provide?

Checklist

  • I have added a new feature and have added tests to go along with it.
  • I have fixed a bug and have added a regression test.
  • I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests.

Copilot AI review requested due to automatic review settings May 12, 2026 20:54
@v4xsh v4xsh requested a review from hkaiser as a code owner May 12, 2026 20:54
@StellarBot
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown
Contributor

@hkaiser hkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hkaiser hkaiser added this to the 2.0.0 milestone May 12, 2026
@hkaiser hkaiser merged commit ec59870 into TheHPXProject:master May 13, 2026
73 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants