DE-325 Update API v1 and v2 03-28-2019 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsi1verthorn
approved these changes
Mar 28, 2019
| @@ -0,0 +1,138 @@ | |||
| # jcapiv2.ProvidersApi | |||
There was a problem hiding this comment.
This ^^^ doesn't seem to follow the pattern of the others
Contributor
Author
There was a problem hiding this comment.
I believe it's the same section vs member of the section difference, just generated in a different way
| { | ||
| "packageName": "jcapiv1", | ||
| "packageVersion": "3.0.0" | ||
| "packageVersion": "3.1.0" |
There was a problem hiding this comment.
Why is the package version 3.1.0 for Python, but 2.2.0 for Go and Ruby?
Contributor
Author
There was a problem hiding this comment.
It's based on the release version, but I'm not sure why/when they diverged.
istevenson-JC
approved these changes
Mar 29, 2019
joshjumpcloud
approved these changes
Apr 5, 2019
This reverts commit 27b204d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates include: