Conversation
added 5 commits
November 14, 2017 10:26
This fixes an issue where the generated code examples were using the wrong import statement: https://github.com/TheJumpCloud/jumpcloud-issues/issues/1274
Using swagger-codegen 2.2.3. Changes are minimal and non-breaking. Mostly fixes the wrong import statement in examples and other misc minor changes.
Using swagger-codegen 2.2.3 and latest swagger spec from Stoplight. - fixes wrong import statement in examples - apply restrictions for associations on user groups and system groups endpoints - bunch of documentation changes in the swagger spec - other misc minor changes
| try: | ||
| # make an API call to retrieve all systemusers: | ||
| users = systemusersAPI.systemusers_list(content_type, accept) | ||
| print users |
Contributor
There was a problem hiding this comment.
Elsewhere the code is using a print("message") format but here we are not, are examples generated as well?
Contributor
Author
There was a problem hiding this comment.
Those are just my own examples. I just added the print statement cause I realized I wasn't doing anything with the result so I might as well print it. I don't think it really matters.
| userGroup = userGroupsAPI.groups_user_get(group_id, content_type, accept) | ||
| # make an API call to retrieve all user groups: | ||
| userGroups = userGroupsAPI.groups_user_list(content_type, accept) | ||
| print userGroups |
Contributor
There was a problem hiding this comment.
Same print usage question here
ebodine-jump
approved these changes
Nov 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade swagger-codegen to 2.2.3 and re-generate code: only a minor update from 2.2.2, so no breaking changes.
This fixes an issue where the generated code examples were using the wrong import statement: https://github.com/TheJumpCloud/jumpcloud-issues/issues/1274
Aside from the swagger-codegen changes, the code has been re-generated with the latest API spec files from Stoplight: