Fix pixelblaze map uploading (AttributeError)#88
Merged
TheMariday merged 2 commits intoTheMariday:mainfrom Mar 29, 2026
Merged
Conversation
Owner
|
Hi there! Thank you so much for reporting this bug! All looks fine to me and I'll merge this in. Please do let me know if you have any feedback or suggestions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On current latest, running
marimapper_upload_mapping_to_pixelblazevia CLI will fail with anAttributeError:This PR just instantiates the type that the factory function returns. I copied the general format that
check_backend_cli.pyused. Tested with an actual pixelblaze board, and this let me upload the map.