-
Notifications
You must be signed in to change notification settings - Fork 15.8k
Working with APIs: Clarify default 'cors' mode behavior in CORS section #28733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We can actually probably just remove the If you can put this on hold for a bit, I'm discussing with the team regarding some other CORS material because there might be an additional thing we need to do on top of removing the mode options references. I'll get back to you once we've discussed that through. |
|
That makes sense. I'll put this on hold for now and wait for your update after the team discussion. |
|
@MaoShizhong There was an Issue + PR I opened regarding this in the past. Maybe it is worth looking into why it was closed and not merged Check #23232 |
|
@wise-king-sullyman Did you ever get round to confirming this in Safari on MacOS? And discussing how CORS can be introduced in the Rails pathway? |
|
My apologies, this slipped through the cracks on me. I just tested in Safari and confirmed that fetch is defaulting to cors mode so I think we should be ok to remove it as @mao-sz suggested. Would you still be interested in making this change @Maddily? I know it has been quite a while since you opened this PR. |
|
@wise-king-sullyman Absolutely. I'm on it. |
|
@mao-sz I've removed the cors references from this lesson as well as Fetching Data In React and Async and Await. Could you confirm if these were all the lessons that mentioned |
mao-sz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks! Sorry it took so long
Because
I wanted to mention the default behavior when sending cross-origin requests using
fetch.This PR
mode: 'cors'` is set by default.mode: 'cors'in the options is good for clarity.Issue
Closes #XXXXX
Additional Information
N/A
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection