Update section Using node-postgres in Express in the Using PostgreSQL course#29063
Merged
KevinMulhern merged 2 commits intoTheOdinProject:mainfrom May 25, 2025
Merged
Update section Using node-postgres in Express in the Using PostgreSQL course#29063KevinMulhern merged 2 commits intoTheOdinProject:mainfrom
KevinMulhern merged 2 commits intoTheOdinProject:mainfrom
Conversation
Mohamedsayhii
changed the title
rlmoser99
requested review from
a team and
bycdiaz
and removed request for
a team
bycdiaz
requested changes
Jan 17, 2025
Member
bycdiaz
left a comment
bycdiaz
left a comment
There was a problem hiding this comment.
@Mohamedsayhii Looks like there are some linter warnings. When you get a chance, can you get these situated?
Fix lesson overview items by adding periods to the end of each item as there have been linter warnings.
Contributor
Author
|
@bycdiaz Can you recheck the changes, i fixed the lints warnings. Sorry for not replying earlier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
Forgetting to change the <role_name> and <role_password> in db/pool.js file can lead to confusion not knowing what went wrong when running the app.
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection