Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3009 +/- ##
=======================================
Coverage 93.02% 93.02%
=======================================
Files 481 481
Lines 43563 43576 +13
Branches 6055 6055
=======================================
+ Hits 40525 40538 +13
Misses 1965 1965
Partials 1073 1073 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbernstein
force-pushed
the
PP-3579-add-visibility-column
branch
from
ac4b6a2 to
eeaa851
Compare
Contributor
Author
|
I'm moving this back to draft as I am seeing a problem testing on minotaur. |
dbernstein
force-pushed
the
PP-3579-add-visibility-column
branch
from
d2178b3 to
4fd8734
Compare
Contributor
Author
|
This one is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two column to the inventory report: visible and visibility_status.
Visible can have values of "true" or "false"
When visible is false, visibility_status is blank.
When visible is true, visibility_status can have the following values:
"manually suppressed" or "filtered".
Manual suppression supercedes filtered in the case where both are true.
Motivation and Context
https://ebce-lyrasis.atlassian.net/browse/PP-3579
Of particular note is the conclusion to the discussion of what the column layout and values should be:
Hi @Danny Bernstein Yes, a two column approach as you’ve outlined makes sense to me. The first that is a boolean: visible/(invisible/hidden/suppressed) and then a second that is the visibility status as you’ve outlined. And per the slack thread it seems like suppressed by collection won’t be an option in the longterm, so there would only be two sources of suppression.How Has This Been Tested?
Unit tests added. Verified manually on minotaur.
Checklist