Add reverse-order sorting for lane facets (PP-3147)#3017
Merged
jonathangreen merged 2 commits intomainfrom Feb 3, 2026
Merged
Conversation
jonathangreen
changed the base branch from
main
to
chore/facets-strict-typing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3017 +/- ##
=======================================
Coverage 93.01% 93.01%
=======================================
Files 481 481
Lines 43607 43625 +18
Branches 6058 6063 +5
=======================================
+ Hits 40561 40578 +17
- Misses 1969 1970 +1
Partials 1077 1077 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonathangreen
force-pushed
the
feature/reverse-order-sorting
branch
2 times, most recently
from
26b6c2b to
b92188b
Compare
When a library enables a sort option (e.g., Author), both directions are now automatically available in feeds: - "Author (A-Z)" - ascending (original) - "Author (Z-A)" - descending (new reverse variant) This allows patrons to sort lanes in reverse order without requiring additional library configuration or significant client-side changes.
jonathangreen
force-pushed
the
feature/reverse-order-sorting
branch
from
b92188b to
ef5ecd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add reverse-order sorting options to the OPDS feed facets. When a library enables a sort option (e.g., "Author"), both directions are now automatically available in feeds:
Changes
ORDER_TITLE_DESC,ORDER_AUTHOR_DESC,ORDER_ADDED_TO_COLLECTION_ASCORDER_FACET_TO_REVERSE_VARIANTmapping to automatically pair base facets with their reverse variantsfacet_groupsproperty to yield reverse variants alongside base facetsMotivation and Context
We have designs that include reverse-order sorting for lanes, but this was not previously supported in the backend. This change enables patrons to sort lanes in either direction without requiring additional library configuration or significant client-side changes.
How Has This Been Tested?
tests/manager/feed/facets/test_reverse_order.pytests/manager/feed/facets/test_feed.pyChecklist