Fix time-dependent test failure in playtime report test#3020
Merged
jonathangreen merged 1 commit intomainfrom Feb 2, 2026
Merged
Fix time-dependent test failure in playtime report test#3020jonathangreen merged 1 commit intomainfrom
jonathangreen merged 1 commit intomainfrom
Conversation
Replace hardcoded year '2025' with dynamically computed year based on the reporting period start date. This prevents the test from failing when the calendar year changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
- Coverage 93.02% 93.01% -0.02%
==========================================
Files 481 481
Lines 43564 43607 +43
Branches 6055 6058 +3
==========================================
+ Hits 40526 40561 +35
- Misses 1965 1969 +4
- Partials 1073 1077 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbernstein
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace hardcoded year '2025' with dynamically computed year based on the reporting period start date in the
test_generate_playtime_reportstest.Motivation and Context
This test started failing in CI on 2026-02-01 because it had the year '2025' hardcoded in the expected folder structure assertions.
The test uses
previous_months(number_of_months=1)to calculate the reporting period, which returns the start of the previous month:How Has This Been Tested?
Checklist