[PP-3653] Remove LCP non-EPUB deprioritize behavior and setting.#3032
[PP-3653] Remove LCP non-EPUB deprioritize behavior and setting.#3032dbernstein merged 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3032 +/- ##
==========================================
- Coverage 93.07% 93.07% -0.01%
==========================================
Files 480 480
Lines 43677 43668 -9
Branches 6028 6026 -2
==========================================
- Hits 40651 40642 -9
Misses 1960 1960
Partials 1066 1066 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonathangreen
left a comment
jonathangreen
left a comment
There was a problem hiding this comment.
Noticed a couple minor things after approving this one that would be nice to get sorted out before merging. Added a couple small comments.
| Revises: 9c3f2b3fba1b | ||
| Create Date: 2026-02-09 | ||
|
|
||
| """ |
There was a problem hiding this comment.
Was this generated with alembic revision? The filename doesn't have the alembic revision ID in it like the rest of our revisions do. Maybe regenerate it to get the correct metadata included?
| op.execute( | ||
| "UPDATE integration_configurations SET settings = settings - 'deprioritize_lcp_non_epubs' " | ||
| "WHERE settings ? 'deprioritize_lcp_non_epubs'" | ||
| ) |
There was a problem hiding this comment.
Minor: Not strictly necessary, but we usually wrap these in sa.text to stop SA from emitting warnings. Might be good to wrap this for consistency.
jonathangreen
left a comment
jonathangreen
left a comment
There was a problem hiding this comment.
I'm going to mark this one is "request changes" to make sure the migration issue gets sorted out before merging.
| @@ -0,0 +1,26 @@ | |||
| """Remove deprioritize_lcp_non_epubs setting | |||
|
|
|||
| Revision ID: a1b2c3d4e5f6 | |||
There was a problem hiding this comment.
Looking at this revision ID, it totally wasn't generated by alembic revision. That looks like something generated by AI. You need to make sure if AI generates your migrations that it generates them via alembic revision instead of just faking it and making up a plausible looking migration file.
There was a problem hiding this comment.
Good catch. I did request AI to use alembic for the revision but clearly I need to be more specific.
dbernstein
force-pushed
the
PP-3653-remove-deprioritize-lcp-feature
branch
from
c872b14 to
714618a
Compare
2 participants
Description
Remove LCP deprioritize setting (deprioritize_lcp_non_epubs)
FormatPrioritiesSettings; remove artificial LCP non-EPUB sort logic.
FormatPriorities with only prioritized_drm_schemes and
prioritized_content_types.
from integration_configurations.settings (JSONB); no schema change.
Motivation and Context
Now that both mobile apps support streaming LCP audiobook ZIP files, we can remove the temporary setting to de-prioritize LCP audiobooks (the actual label for the setting is “De-Prioritize LCP non-EPUBs”)
https://ebce-lyrasis.atlassian.net/browse/PP-3653
How Has This Been Tested?
Checklist