Add type annotation to container module variable#3042
Merged
jonathangreen merged 1 commit intomainfrom Feb 11, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3042 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 480 480
Lines 43711 43711
Branches 6029 6029
=======================================
Hits 40669 40669
Misses 1972 1972
Partials 1070 1070 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
705f4e3 to
bc52b67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a type annotation (
Services | None) to the_container_instancemodule-level variable incontainer.py.Motivation and Context
Mypy intermittently complains about the type of
_container_instancebeingNone. Without an explicit annotation, mypy infers the type from the initial assignment (None), which can cause it to flag usages where the variable holds aServicesinstance. Adding the explicitServices | Noneannotation makes the intended type clear and prevents these sporadic type errors.How Has This Been Tested?
This is a type annotation-only change with no runtime behavior change. Pre-commit hooks passed successfully.
Checklist