Add type annotations to SIP2 client and provider#3091
Merged
jonathangreen merged 1 commit intomainfrom Mar 3, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3091 +/- ##
==========================================
- Coverage 93.20% 93.18% -0.02%
==========================================
Files 491 491
Lines 45248 45256 +8
Branches 6222 6224 +2
==========================================
Hits 42172 42172
- Misses 1992 1997 +5
- Partials 1084 1087 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add comprehensive type annotations to the SIP2 authentication client and provider modules, and refactor the SIP2 field descriptor system to use idiomatic Python patterns.
Motivation and Context
The SIP2 modules were excluded from mypy type checking. This change adds full type coverage, enabling static analysis to catch bugs in this critical authentication path. The field descriptor refactoring replaces a non-standard
_add()pattern with standard Python descriptors, improving readability and IDE support.How Has This Been Tested?
username: strcontract.Noneusername cases that are no longer reachable.Checklist