Log PatronAuthResult details on server-side validation failure#3145
Merged
jonathangreen merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
When server_side_validation() fails, the PatronAuthResult contains the failure reason but was previously discarded. Now capture and log the result details at INFO level to aid debugging authentication issues.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3145 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 493 493
Lines 45579 45581 +2
Branches 6252 6252
=======================================
+ Hits 42511 42513 +2
Misses 1982 1982
Partials 1086 1086 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonathangreen
deleted the
feature/log-patron-auth-result-on-validation-failure
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
server_side_validation()fails inBasicAuthenticationProvider.authenticate(), thePatronAuthResultobject contains the failure reason but previouslyNonewas returned with no logging. This change captures the result and logs the failure details at INFO level.Motivation and Context
This would have helped while troubleshooting CM authentication errors (see slack thread). The
PatronAuthResult.detailsfield contains the specific failure reason (e.g., regex mismatch), but it was being silently discarded, making it difficult to diagnose patron authentication issues in production.How Has This Been Tested?
Checklist