Skip to content

Conversation

@vckttr
Copy link
Collaborator

@vckttr vckttr commented Jan 11, 2025

No description provided.

uses: Swisyn/android-version-generator-actions@v1.5
with:
gradlePath: app/build.gradle.kts
versionCode: ${{github.run_number}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to signal nightly versions here? Not sure if semver supports this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as i've got versionCode is an integer, versionName is a string

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we should push every commit to releases tab

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the thought process for main always creating a downloadable release is so that non-technical testers (e.g. Dark Wolf) are able to test the app at any time.
I'm trying to get a Google Play app working so we can deploy test builds in the future

@ISNIT0
Copy link
Member

ISNIT0 commented Jan 11, 2025

I approved this - I think we'll want to change versioning behavior fairly soon, but worth doing this now for testability etc.

Thanks @vckttr !

@vckttr vckttr merged commit 00d27fb into main Jan 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants