Skip to content

Conversation

@xezon
Copy link

@xezon xezon commented Sep 5, 2025

This change simplifies the user options for the cursor capture mode.

Options.ini before

CursorCaptureMode = Auto

The values are: None, InGame, Always, Auto. Albeit the option is a simple one liner, the user would not intuitively understand what options are available for this enum and what these options really mean.

Options.ini after

CursorCaptureEnabledInFullscreenGame = yes
CursorCaptureEnabledInFullscreenMenu = yes
CursorCaptureEnabledInWindowedGame = yes
CursorCaptureEnabledInWindowedMenu = no

The user can intuitively understand what the options are and how to tweak them.

TODO

  • Replicate in Generals

@xezon xezon added Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker ThisProject The issue was introduced by this project, or this task is specific to this project labels Sep 5, 2025
@xezon xezon changed the title tweak(options): Simplify the user options for the cursor capture mode tweak(options): Simplify Cursor Capture user options Sep 5, 2025
@xezon xezon changed the title tweak(options): Simplify Cursor Capture user options tweak(options): Simplify user options for Cursor Capture Sep 5, 2025
Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

@xezon xezon force-pushed the xezon/tweak-cursor-mode-options branch from 30babb7 to 5917093 Compare September 26, 2025 18:42
@xezon
Copy link
Author

xezon commented Sep 26, 2025

Replicated in Generals with no tangible conflicts.

@xezon xezon merged commit 63ec8d0 into TheSuperHackers:main Sep 27, 2025
18 checks passed
@xezon xezon deleted the xezon/tweak-cursor-mode-options branch September 27, 2025 06:50
@ElTioRata
Copy link

This PR affected GUIEdit and now my cursor cannot move outside the workspace.

@xezon
Copy link
Author

xezon commented Sep 27, 2025

Please create bug report if it is a bug.

fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
…kers#1541)

Replaces CursorCaptureMode with the following options in Options.ini:

CursorCaptureEnabledInFullscreenGame=yes
CursorCaptureEnabledInFullscreenMenu=yes
CursorCaptureEnabledInWindowedGame=yes
CursorCaptureEnabledInWindowedMenu=no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Is new feature or request Minor Severity: Minor < Major < Critical < Blocker ThisProject The issue was introduced by this project, or this task is specific to this project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants