forked from electronicarts/CnC_Generals_Zero_Hour
-
Notifications
You must be signed in to change notification settings - Fork 117
tweak(options): Simplify user options for Cursor Capture #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xezon
merged 3 commits into
TheSuperHackers:main
from
xezon:xezon/tweak-cursor-mode-options
Sep 27, 2025
Merged
tweak(options): Simplify user options for Cursor Capture #1541
xezon
merged 3 commits into
TheSuperHackers:main
from
xezon:xezon/tweak-cursor-mode-options
Sep 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauller
reviewed
Sep 26, 2025
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp
Outdated
Show resolved
Hide resolved
Mauller
approved these changes
Sep 26, 2025
Mauller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall
30babb7 to
5917093
Compare
Author
|
Replicated in Generals with no tangible conflicts. |
|
This PR affected GUIEdit and now my cursor cannot move outside the workspace. |
Author
|
Please create bug report if it is a bug. |
4 tasks
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…kers#1541) Replaces CursorCaptureMode with the following options in Options.ini: CursorCaptureEnabledInFullscreenGame=yes CursorCaptureEnabledInFullscreenMenu=yes CursorCaptureEnabledInWindowedGame=yes CursorCaptureEnabledInWindowedMenu=no
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
Is new feature or request
Minor
Severity: Minor < Major < Critical < Blocker
ThisProject
The issue was introduced by this project, or this task is specific to this project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change simplifies the user options for the cursor capture mode.
Options.ini before
The values are:
None,InGame,Always,Auto. Albeit the option is a simple one liner, the user would not intuitively understand what options are available for this enum and what these options really mean.Options.ini after
The user can intuitively understand what the options are and how to tweak them.
TODO