bugfix(module): Fix missing horde condition of Nationalism and Fanaticism weapon bonuses

[xezon]

Merge with Rebase

• Relates to China Nationalism (and Patriotism) apply fire rate bonus to units regardless of Horde bonus #173
• Closes [GEN][ZH] Fix nationalism and fanaticism bonuses being applied independent of horde status #385
• Closes [GEN][ZH] Fix nationalism and patriotism/fanaticism being applied when not in a horde #1300
• Merge after unify(module): Merge HordeUpdate and related code #1813

This change fixes the missing horde condition of Nationalism and Fanaticism weapon bonuses.

The fix is opt-in by setting Action = HORDE_FIXED in HordeUpdate behavior modules.

By default, the game uses the new fixed behavior, but the retail game will still use the old bugged behavior, because all modules explicitly set Action = HORDE.

TODO

• Test this works correctly after refactor
• Replicate in Generals

[xezon]

Just realized this change also closes pending pull #1300

[xezon]

I have recreated the commits. First commit is a refactor to improve and simplify the Horde Bonus code, and then the second commit implements the bug fix. I have also put it behind RETAIL_COMPATIBLE_CRC.

[Mauller]

Look good.

Might want to manually replicate this to generals since the codes a bit different and fanaticism doesn't exist there etc.

[xezon]

Replication to Generals is difficult because of major conflicts. Needs #1813 first.

[xezon]

Replicated in Generals with mini conflict

$ git apply -p2 --directory=Generals --reject --whitespace=fix changes.patch
Checking patch Generals/Code/GameEngine/Include/Common/Player.h...
Hunk #1 succeeded at 289 (offset -20 lines).
Checking patch Generals/Code/GameEngine/Include/GameLogic/Module/AIUpdate.h...
error: while searching for:
class JetAIUpdate;

enum AIStateType CPP_11(: Int);
enum ObjectID CPP_11(: Int);



error: patch failed: Generals/Code/GameEngine/Include/GameLogic/Module/AIUpdate.h:57
Hunk #2 succeeded at 547 (offset -14 lines).
Checking patch Generals/Code/GameEngine/Include/GameLogic/Module/HordeUpdate.h...
Checking patch Generals/Code/GameEngine/Source/Common/RTS/Player.cpp...
Hunk #1 succeeded at 2511 (offset -481 lines).
Hunk #2 succeeded at 2522 (offset -481 lines).
Checking patch Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp...
Hunk #1 succeeded at 4426 (offset -252 lines).
Hunk #2 succeeded at 4554 (offset -252 lines).
Checking patch Generals/Code/GameEngine/Source/GameLogic/Object/Update/HordeUpdate.cpp...
Hunk #6 succeeded at 392 (offset -10 lines).
Applied patch Generals/Code/GameEngine/Include/Common/Player.h cleanly.
Applying patch Generals/Code/GameEngine/Include/GameLogic/Module/AIUpdate.h with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Applied patch Generals/Code/GameEngine/Include/GameLogic/Module/HordeUpdate.h cleanly.
Applied patch Generals/Code/GameEngine/Source/Common/RTS/Player.cpp cleanly.
Applied patch Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp cleanly.
Applied patch Generals/Code/GameEngine/Source/GameLogic/Object/Update/HordeUpdate.cpp cleanly.

$ git apply -p2 --directory=Generals --reject --whitespace=fix changes.patch                           Checking patch Generals/Code/GameEngine/Include/GameLogic/Module/AIUpdate.h...
Hunk #1 succeeded at 552 (offset -13 lines).
Checking patch Generals/Code/GameEngine/Include/GameLogic/Module/HordeUpdate.h...
Checking patch Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp...
Hunk #1 succeeded at 4501 (offset -252 lines).
Hunk #2 succeeded at 4546 (offset -252 lines).
Checking patch Generals/Code/GameEngine/Source/GameLogic/Object/Update/HordeUpdate.cpp...
Applied patch Generals/Code/GameEngine/Include/GameLogic/Module/AIUpdate.h cleanly.
Applied patch Generals/Code/GameEngine/Include/GameLogic/Module/HordeUpdate.h cleanly.
Applied patch Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp cleanly.
Applied patch Generals/Code/GameEngine/Source/GameLogic/Object/Update/HordeUpdate.cpp cleanly.