unify(module): Merge HordeUpdate and related code #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xezon
added
Gen
Merged
2 tasks
Mauller
approved these changes
Nov 6, 2025
Mauller
left a comment
Mauller
left a comment
There was a problem hiding this comment.
Looks okay, seemed odd at first in places but i get what it's doing.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Author
|
Tested Horde and Nationalism. Worked. Also tested failing Terrain Decal lookup. Works by showing pink placeholder texture.
|
|
Would be good to rebase this with main so we can double check the implementation against replays. |
xezon
force-pushed
the
xezon/merge-hordebonus
branch
from
aaa53e1 to
015c64b
Compare
Author
|
Done |
|
Tested with relevant replays and i could see units going in and out of horde without mismatch, also same when nationalism was in play. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change merges the HordeUpdate module and related code.
Generals gets the following functional HordeUpdate field: "AllowedNationalism"
TODO