bugfix(view): Fix camera terrain height adjustment in Replay playback #1597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyaero42
approved these changes
Sep 18, 2025
Skyaero42
left a comment
Skyaero42
left a comment
There was a problem hiding this comment.
Don't understand why you would want 'scripted' behavior in replays. Somebody at EA must have not been fed banana's.
Fix looks good.
Author
|
I suspect the scripted camera stuff is for campaign cutscenes. |
1 task
xezon
force-pushed
the
xezon/fix-camera-terrain-adjustment-in-replays
branch
from
39d4120 to
eec7334
Compare
Author
|
Replicated in Generals without conflicts. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the camera terrain height adjustment in Replay playback. Originally the camera would not raise or lower when scrolling over a mountain or valley.
TODO