Skip to content

bugfix(fps): Fix mouse wheel zoom speed and decouple zoom update from logic step #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2025
Merged

bugfix(fps): Fix mouse wheel zoom speed and decouple zoom update from logic step #1587

merged 2 commits into from
Sep 20, 2025

Conversation

@xezon
Copy link

@xezon xezon commented Sep 17, 2025 •
edited
Loading

This change fixes the mouse wheel zoom speed.

This bug was introduced by #1451

TODO

  • Replicate in Generals

@xezon xezon added Bug Something is not working right, typically is user facing Minor Severity: Minor < Major < Critical < Blocker ThisProject The issue was introduced by this project, or this task is specific to this project labels Sep 17, 2025
@xezon xezon mentioned this pull request Sep 17, 2025
Merged
2 tasks
@ElTioRata
Copy link

ElTioRata commented Sep 17, 2025

The zoom change is more instant at higher FPS.

8mb.video-oxY-PWatJMcD.mp4

@xezon xezon force-pushed the xezon/fix-mouse-wheel-zoom branch from 1f75884 to 83d5f14 Compare September 18, 2025 06:54
@xezon xezon changed the title bugfix(input): Fix mouse wheel zoom speed bugfix(input): Fix mouse wheel zoom speed and decouple zoom update from logic step Sep 18, 2025
@xezon xezon added Gen Relates to Generals ZH Relates to Zero Hour and removed ThisProject The issue was introduced by this project, or this task is specific to this project labels Sep 18, 2025
@xezon
Copy link
Author

xezon commented Sep 18, 2025 •
edited
Loading

The zoom change is more instant at higher FPS.

Fixed.

@MrS-ibra
Copy link

MrS-ibra commented Sep 18, 2025

Mouse wheel zoom works normally during gameplay, but it's still noticeably slow in replay mode.

@xezon
Copy link
Author

xezon commented Sep 19, 2025

Mouse wheel zoom works normally during gameplay, but it's still noticeably slow in replay mode.

Indeed. After investigation I found fix #1597 also fixes the Replay zoom speed. So that problem is covered with the other change.

@xezon xezon force-pushed the xezon/fix-mouse-wheel-zoom branch from 83d5f14 to 1802f65 Compare September 19, 2025 08:28
Mauller
Mauller approved these changes Sep 20, 2025
View reviewed changes
Copy link

@Mauller Mauller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xezon
Copy link
Author

xezon commented Sep 20, 2025

Replicated in Generals without conflicts

@xezon xezon changed the title bugfix(input): Fix mouse wheel zoom speed and decouple zoom update from logic step bugfix(fps): Fix mouse wheel zoom speed and decouple zoom update from logic step Sep 20, 2025
@xezon xezon merged commit b1eac2a into TheSuperHackers:main Sep 20, 2025
19 checks passed
@xezon xezon deleted the xezon/fix-mouse-wheel-zoom branch September 20, 2025 10:17
@xezon xezon mentioned this pull request Sep 29, 2025
Merged
1 task
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
@xezon
bugfix(fps): Fix mouse wheel zoom speed and decouple zoom update from…
fea2031 
… logic step (TheSuperHackers#1587)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mauller Mauller Mauller approved these changes

Assignees

No one assigned

Labels

Bug Something is not working right, typically is user facing Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xezon @ElTioRata @MrS-ibra @Mauller