Skip to content

fix: crash when replay file is deleted during version mismatch prompt #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+36 −2
Draft

fix: crash when replay file is deleted during version mismatch prompt #1837

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf32f04
Validate replay file exists before attempting playback in version mis…
bobtista Nov 12, 2025
66502a8
Delay playback mode assignment until after replay file opens successf…
bobtista Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Generals/Code/GameEngine/Source/Common/Recorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,7 +1196,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
}
}

m_mode = RECORDERMODETYPE_PLAYBACK;
// TheSuperHackers @bugfix bobtista Don't set playback mode until after file opens successfully
// to prevent crash if playback is updated while m_file is NULL

ReplayHeader header;
header.forPlayback = TRUE;
Expand All @@ -1207,6 +1208,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
return FALSE;
}

m_mode = RECORDERMODETYPE_PLAYBACK;

#ifdef DEBUG_CRASHING
Bool versionStringDiff = header.versionString != TheVersion->getUnicodeVersion();
Bool versionTimeStringDiff = header.versionTimeString != TheVersion->getUnicodeBuildTime();
Expand Down
14 changes: 14 additions & 0 deletions Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,20 @@ void reallyLoadReplay(void)
AsciiString asciiFilename;
asciiFilename.translate(filename);

// TheSuperHackers @bugfix bobtista Check if file still exists before attempting playback
// to prevent crash when file is deleted during version mismatch prompt
RecorderClass::ReplayHeader header;
ReplayGameInfo info;
const MapMetaData *mapData;

if(!readReplayMapInfo(asciiFilename, header, info, mapData))
{
UnicodeString title = TheGameText->FETCH_OR_SUBSTITUTE("GUI:ReplayFileNotFoundTitle", L"REPLAY NOT FOUND");
UnicodeString body = TheGameText->FETCH_OR_SUBSTITUTE("GUI:ReplayFileNotFound", L"This replay cannot be loaded because the file no longer exists on this device.");
MessageBoxOk(title, body, NULL);
return;
}

TheRecorder->playbackFile(asciiFilename);

if(parentReplayMenu != NULL)
Expand Down
5 changes: 4 additions & 1 deletion GeneralsMD/Code/GameEngine/Source/Common/Recorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1199,7 +1199,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
}
}

m_mode = RECORDERMODETYPE_PLAYBACK;
// TheSuperHackers @bugfix bobtista Don't set playback mode until after file opens successfully
// to prevent crash if playback is updated while m_file is NULL

ReplayHeader header;
header.forPlayback = TRUE;
Expand All @@ -1210,6 +1211,8 @@ Bool RecorderClass::playbackFile(AsciiString filename)
return FALSE;
}

m_mode = RECORDERMODETYPE_PLAYBACK;

#ifdef DEBUG_CRASHING
Bool versionStringDiff = header.versionString != TheVersion->getUnicodeVersion();
Bool versionTimeStringDiff = header.versionTimeString != TheVersion->getUnicodeBuildTime();
Expand Down
14 changes: 14 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,20 @@ void reallyLoadReplay(void)
AsciiString asciiFilename;
asciiFilename.translate(filename);

// TheSuperHackers @bugfix bobtista Check if file still exists before attempting playback
// to prevent crash when file is deleted during version mismatch prompt
RecorderClass::ReplayHeader header;
ReplayGameInfo info;
const MapMetaData *mapData;

if(!readReplayMapInfo(asciiFilename, header, info, mapData))
{
UnicodeString title = TheGameText->FETCH_OR_SUBSTITUTE("GUI:ReplayFileNotFoundTitle", L"REPLAY NOT FOUND");
UnicodeString body = TheGameText->FETCH_OR_SUBSTITUTE("GUI:ReplayFileNotFound", L"This replay cannot be loaded because the file no longer exists on this device.");
MessageBoxOk(title, body, NULL);
return;
}

TheRecorder->playbackFile(asciiFilename);

if(parentReplayMenu != NULL)
Expand Down
Loading