Skip to content

refactor: Use new utility logic for handling observed player behaviour #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 25, 2025
Merged

refactor: Use new utility logic for handling observed player behaviour #1861

merged 7 commits into from
Nov 25, 2025

Conversation

@Stubbjax
Copy link

@Stubbjax Stubbjax commented Nov 15, 2025

Fixes #1859

This change adjusts various conditional behaviour concerning the currently observed player to utilise the new utility logic where applicable.

@Stubbjax Stubbjax self-assigned this Nov 15, 2025
@Stubbjax Stubbjax added Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Refactor Edits the code with insignificant behavior changes, is never user facing labels Nov 15, 2025
xezon
xezon reviewed Nov 17, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you also make a pass on getCurrentlyViewedPlayerRelationship and getCurrentlyViewedPlayerSide?

@xezon xezon added Design Is a matter of game design ThisProject The issue was introduced by this project, or this task is specific to this project and removed Refactor Edits the code with insignificant behavior changes, is never user facing labels Nov 17, 2025
@Stubbjax
Copy link
Author

Stubbjax commented Nov 18, 2025

Did you also make a pass on getCurrentlyViewedPlayerRelationship and getCurrentlyViewedPlayerSide?

Regarding getCurrentlyViewedPlayerRelationship:

There is a single usage of this function in the radar logic, which I believe is valid. We do not want to consider the relationship of a defeated player when determining whether to show stealthed units on the radar. If the player is not observing anyone in particular, we want a NEUTRAL relationship rather than the local player's.

Regarding getCurrentlyViewedPlayerSide:

There is a single usage of this function in the EVA logic. It looks like this is not needed as the logic falls back to the local player's side. I shall update this.

xezon
xezon reviewed Nov 20, 2025
View reviewed changes
xezon
xezon approved these changes Nov 25, 2025
View reviewed changes
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks proper.

@xezon xezon merged commit 8d675a8 into TheSuperHackers:main Nov 25, 2025
23 checks passed
@Stubbjax Stubbjax deleted the update-observer-logic branch November 26, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon approved these changes

Assignees

@Stubbjax Stubbjax

Labels

Design Is a matter of game design Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ThisProject The issue was introduced by this project, or this task is specific to this project ZH Relates to Zero Hour

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review observer and look-at player features

2 participants

@Stubbjax @xezon