Skip to content

nit: remove nader comments round 2 #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

nit: remove nader comments round 2 #1876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
98ec5f3
nit: remove nader comments
bobtista Nov 18, 2025
14a7ef0
nit: remove empty lines leftover after comment removal
bobtista Nov 18, 2025
318f061
manually clear out extra lines near where we removed comments
bobtista Nov 18, 2025
b90d98e
remove added by saad comments
bobtista Nov 18, 2025
7f2be45
replicate changes to some files to GeneralsMD
bobtista Nov 18, 2025
a94c874
restored some comments, fixed an indent, more space removal, replicat…
bobtista Nov 19, 2025
d8e0c90
a few more empty lines
bobtista Nov 19, 2025
079c7cc
a few more in GeneralsMD, plus taipo fix
bobtista Nov 19, 2025
f2b9698
couple more nits
bobtista Nov 28, 2025
6f89eef
6 more saad comments cleaned up
bobtista Nov 29, 2025
32509cc
nit: more consistency fixes
bobtista Nov 29, 2025
a4ca6cb
nit: remove comment
bobtista Nov 29, 2025
b52d6e9
remove empty line
bobtista Nov 29, 2025
c43e0ae
more cleanup
bobtista Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Core/GameEngine/Source/Common/Audio/GameAudio.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ AudioManager::AudioManager() :
m_hardwareAccel(FALSE),
m_musicPlayingFromCD(FALSE)
{
// Added by Sadullah Nader
m_adjustedVolumes.clear();
m_audioRequests.clear();
m_listenerPosition.zero();
Expand All @@ -166,8 +165,6 @@ AudioManager::AudioManager() :
m_systemSoundVolume = 0.0f;
m_systemSpeechVolume = 0.0f;
m_volumeHasChanged = FALSE;
//

m_listenerOrientation.set(0.0, 1.0, 0.0);
theAudioHandlePool = AHSV_FirstHandle;
m_audioSettings = NEW AudioSettings;
Expand Down
3 changes: 0 additions & 3 deletions Core/GameEngine/Source/Common/System/RAMFile.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,7 @@
RAMFile::RAMFile()
: m_size(0),
m_data(NULL),
//Added By Sadullah Nader
//Initializtion(s) inserted
m_pos(0)
//
{

}
Expand Down
3 changes: 0 additions & 3 deletions Core/GameEngine/Source/Common/System/XferCRC.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@ XferCRC::XferCRC( void )
{

m_xferMode = XFER_CRC;
//Added By Sadullah Nader
//Initialization(s) inserted
m_crc = 0;
//
}

//-------------------------------------------------------------------------------------------------
Expand Down
3 changes: 0 additions & 3 deletions Core/GameEngine/Source/GameNetwork/Connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,12 @@ Connection::Connection() {
m_frameGrouping = 1;
m_isQuitting = false;
m_quitTime = 0;
// Added By Sadullah Nader
// clearing out the latency tracker
m_averageLatency = 0.0f;
Int i;
for(i = 0; i < CONNECTION_LATENCY_HISTORY_LENGTH; i++)
{
m_latencies[i] = 0.0f;
}
// End Add
}

/**
Expand Down
2 changes: 0 additions & 2 deletions Core/GameEngine/Source/GameNetwork/DisconnectManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@

DisconnectManager::DisconnectManager()
{
// Added By Sadullah Nader
// Initializations missing and needed
Int i;
m_currentPacketRouterIndex = 0;
m_lastFrame = 0;
Expand Down
7 changes: 0 additions & 7 deletions Core/GameEngine/Source/GameNetwork/DownloadManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,7 @@ DownloadManager::DownloadManager()
{
m_download = NEW CDownload(this);
m_wasError = m_sawEnd = false;

//Added By Sadullah Nader
//Initializations missing and needed

m_queuedDownloads.clear();

//
Copy link

@Skyaero42 Skyaero42 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also check for unnecessary blank lines that result from the removal of these comments.

Copy link
Author

@bobtista bobtista Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I found a bunch and removed them. At some point we should use prettier or clang-tidy or something and unify the formatting across the repo.

Copy link

@Skyaero42 Skyaero42 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few left that imho should be dealt with in this PR, because they are part of the comments

e.g.

    // End Add
    
		// Added By Sadullah Nader
		// Initialization missing and needed

		m_putInContainerName.clear();

I think you need to look above and below the removed comments and remove empty lines

Copy link
Author

@bobtista bobtista Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been going through and manually looking at files for a few hours now. Sometimes the empty lines above or below where Nader's comments lived are perfectly reasonable - eg the blocks of code would have had an empty line anyway, eg when variables are grouped or there are just newlines every n lines of assignments for style/readabilty. I'm about 1/4 of the way through reviewing all of the comments individually, addressing the empty lines around them, and feeling like I'm really using my time poorly.

If you have an idea for a script here I'm happy to chat about this more. For now I'm going to take a break. I'll push the latest changes when able (git is down) EDIT: pushed latest


m_statusString = TheGameText->fetch("FTP:StatusIdle");

// ----- Initialize Winsock -----
Expand Down
4 changes: 0 additions & 4 deletions Core/GameEngine/Source/GameNetwork/FirewallHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,12 @@ FirewallHelperClass * createFirewallHelper()

FirewallHelperClass::FirewallHelperClass(void)
{
//Added Sadullah Nader
//Initializations missing and needed
m_currentTry = 0;
m_numManglers = 0;
m_numResponses = 0;
m_packetID = 0;
m_timeoutLength = 0;
m_timeoutStart = 0;
//

m_behavior = FIREWALL_TYPE_UNKNOWN;
m_lastBehavior = FIREWALL_TYPE_UNKNOWN;
m_sourcePortAllocationDelta = 0;
Expand Down
3 changes: 0 additions & 3 deletions Core/GameEngine/Source/GameNetwork/FrameData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,8 @@ FrameData::FrameData()
m_commandList = NULL;
m_commandCount = 0;
m_frameCommandCount = -1;
//Added By Sadullah Nader
//Initializations missing and needed
m_lastFailedCC = 0;
m_lastFailedFrameCC = 0;
//
}

/**
Expand Down
3 changes: 0 additions & 3 deletions Core/GameEngine/Source/GameNetwork/FrameMetrics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@

FrameMetrics::FrameMetrics()
{
//Added By Sadullah Nader
//Initializations missing and needed
m_averageFps = 0.0f;
m_averageLatency = 0.0f;
m_cushionIndex = 0;
Expand All @@ -44,7 +42,6 @@ FrameMetrics::FrameMetrics()
m_pendingLatencies = NEW time_t[MAX_FRAMES_AHEAD];
for(Int i = 0; i < MAX_FRAMES_AHEAD; i++)
m_pendingLatencies[i] = 0;
//
m_fpsList = NEW Real[TheGlobalData->m_networkFPSHistoryLength];
m_latencyList = NEW Real[TheGlobalData->m_networkLatencyHistoryLength];
}
Expand Down
4 changes: 0 additions & 4 deletions Core/GameEngine/Source/GameNetwork/GameInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,17 +307,13 @@ void GameInfo::reset( void )
m_useStats = TRUE;
m_surrendered = FALSE;
m_oldFactionsOnly = FALSE;
// Added By Sadullah Nader
// Initializations missing and needed
// m_localIP = 0; // BGC - actually we don't want this to be reset since the m_localIP is
// set properly in the constructor of LANGameInfo which uses this as a base class.
m_mapCRC = 0;
m_mapSize = 0;
m_superweaponRestriction = 0;
m_startingCash = TheGlobalData->m_defaultStartingCash;

//

for (Int i=0; i<MAX_SLOTS; ++i)
{
if (m_slot[i])
Expand Down
8 changes: 0 additions & 8 deletions Core/GameEngine/Source/GameNetwork/GameSpy/PeerDefs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ void GameSpyInfo::reset( void )
m_localName = "";
m_localProfileID = 0;
m_maxMessagesPerUpdate = 100;

// Added By Sadullah Nader
// Initialization missing and needed
m_disallowAsainText = FALSE;
m_disallowNonAsianText = FALSE;
m_disconReason = 0;
Expand All @@ -100,15 +97,10 @@ void GameSpyInfo::reset( void )
m_pingString.clear();
m_rawConfig.clear();
m_rawMotd.clear();
//

m_internalIP = m_externalIP = 0;

m_savedIgnoreMap.clear();
m_preorderPlayers.clear();

m_cachedLocalPlayerStats.reset();

m_additionalDisconnects = -1;
}

Expand Down
2 changes: 0 additions & 2 deletions Core/GameEngine/Source/GameNetwork/GameSpy/StagingRoomGameInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ GameSpyGameSlot::GameSpyGameSlot()
m_rankPoints = 0;
m_favoriteSide = 0;
m_pingInt = 0;
// Added By Sadullah Nader
// Initializations missing and needed
m_profileID = 0;
m_pingStr.clear();
}
Expand Down
10 changes: 1 addition & 9 deletions Core/GameEngine/Source/GameNetwork/GameSpy/Thread/PeerThread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,8 @@ class PeerThreadClass : public ThreadClass
public:
PeerThreadClass() : ThreadClass()
{
//Added By Sadullah Nader
//Initializations inserted
m_roomJoined = m_allowObservers = m_hasPassword = FALSE;
m_useStats = TRUE;
m_useStats = TRUE;
m_exeCRC = m_iniCRC = 0;
m_gameVersion = 0;
m_ladderPort = 0;
Expand All @@ -193,24 +191,18 @@ class PeerThreadClass : public ThreadClass
m_qmGroupRoom = 0;
m_sawEndOfEnumPlayers = m_sawMatchbot = FALSE;
m_sawCompleteGameList = FALSE;
//
m_isConnecting = m_isConnected = false;
m_groupRoomID = m_profileID = 0;
m_nextStagingServer = 1; m_stagingServers.clear();
m_pingStr = ""; m_mapName = ""; m_ladderIP = ""; m_isHosting = false;
for (Int i=0; i<MAX_SLOTS; ++i)
{
m_playerNames[i] = "";

//Added by Sadullah Nader
//Initializations
m_playerColors[i] = 0;
m_playerFactions[i] = 0;
m_playerLosses[i] = 0;
m_playerProfileID[i] = 0;
m_playerWins[i] = 0;

//
}
}

Expand Down
3 changes: 0 additions & 3 deletions Core/GameEngine/Source/GameNetwork/GameSpy/Thread/PersistentStorageThread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1107,11 +1107,8 @@ void PSPlayerStats::reset( void )
desyncsInARow = 0;
maxDesyncsInARow = 0;
lastLadderPort = 0;

//Added By Sadullah Nader
maxQMwinsInARow = 0;
QMwinsInARow = 0;
//
}

//-------------------------------------------------------------------------
Expand Down
3 changes: 0 additions & 3 deletions Core/GameEngine/Source/GameNetwork/LANGameInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,8 @@ Bool LANGameSlot::isLocalPlayer( void ) const

LANGameInfo::LANGameInfo()
{
//Added By Sadullah Nader
//Initializtions missing and needed
m_lastHeard = 0;
m_next = NULL;
//
for (Int i = 0; i< MAX_SLOTS; ++i)
setSlotPointer(i, &m_LANSlot[i]);

Expand Down
4 changes: 0 additions & 4 deletions Core/GameEngine/Source/GameNetwork/NAT.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,6 @@ NAT *TheNAT = NULL;

NAT::NAT()
{
//Added By Sadullah Nader
//Initializations inserted
m_beenProbed = FALSE;
m_connectionPairIndex = 0;
m_connectionRound = 0;
Expand All @@ -161,11 +159,9 @@ NAT::NAT()
m_spareSocketPort = 0;
m_startingPortNumber = 0;
m_targetNodeNumber = 0;
//
m_transport = NULL;
m_slotList = NULL;
m_roundTimeout = 0;

m_maxNumRetriesAllowed = 10;
m_packetID = 0x7f00;
}
Expand Down
11 changes: 0 additions & 11 deletions Core/GameEngine/Source/GameNetwork/NetCommandMsg.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,9 @@
*/
NetCommandMsg::NetCommandMsg()
{
//Added By Sadullah Nader
//Initializations inserted
m_executionFrame = 0;
m_id = 0;
m_playerID = 0;

//
m_timestamp = 0;
m_referenceCount = 1; // start this off as 1. This means that an "attach" is implied by creating a NetCommandMsg object.
m_commandType = NETCOMMANDTYPE_UNKNOWN;
Expand Down Expand Up @@ -90,12 +86,8 @@ Int NetCommandMsg::getSortNumber() {
* Constructor with no argument, sets everything to default values.
*/
NetGameCommandMsg::NetGameCommandMsg() : NetCommandMsg() {
//Added By Sadullah Nader
//Initializations inserted
m_argSize = 0;
m_numArgs = 0;
//

m_type = (GameMessage::Type)0;
m_commandType = NETCOMMANDTYPE_GAMECOMMAND;
m_argList = NULL;
Expand Down Expand Up @@ -714,10 +706,7 @@ UnicodeString NetDisconnectChatCommandMsg::getText() {
NetChatCommandMsg::NetChatCommandMsg() : NetCommandMsg()
{
m_commandType = NETCOMMANDTYPE_CHAT;
//added by Sadullah Nader
//Initializations inserted
m_playerMask = 0;
//
}

/**
Expand Down
5 changes: 0 additions & 5 deletions Core/GameEngine/Source/GameNetwork/NetCommandWrapperList.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,7 @@

NetCommandWrapperListNode::NetCommandWrapperListNode(NetWrapperCommandMsg *msg)
{
//Added By Sadullah Nader
//Initializations inserted
m_next = NULL;

//

m_numChunks = msg->getNumChunks();
m_chunksPresent = NEW Bool[m_numChunks]; // pool[]ify
m_numChunksPresent = 0;
Expand Down
4 changes: 0 additions & 4 deletions Core/GameEngine/Source/GameNetwork/Network.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,15 +265,11 @@ NetworkInterface *NetworkInterface::createNetwork()
*/
Network::Network()
{
//Added By Sadullah Nader
//Initializations inserted
m_checkCRCsThisFrame = FALSE;
m_didSelfSlug = FALSE;
m_frameDataReady = FALSE;
m_isStalling = FALSE;
m_sawCRCMismatch = FALSE;
//

m_conMgr = NULL;
m_messageWindow = NULL;

Expand Down
3 changes: 0 additions & 3 deletions Core/Libraries/Source/WWVegas/WW3D2/render2dsentence.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,6 @@ void Render2DSentenceClass::Build_Sentence_Centered (const WCHAR *text, int *hkX
if( ParseHotKey && (*word == L'&') && (*word+1 != 0) && (*word+1 > L' ') && (*word+1 != L'\n'))
{
int offset = 0;
//Added By Saad
if (word_width != 0 )
{
const WCHAR *word_back = word;
Expand All @@ -796,7 +795,6 @@ void Render2DSentenceClass::Build_Sentence_Centered (const WCHAR *text, int *hkX
offset =-1;
}
}
//
*word++;
calcHotKeyX = true;
}
Expand Down Expand Up @@ -853,7 +851,6 @@ void Render2DSentenceClass::Build_Sentence_Centered (const WCHAR *text, int *hkX
//
word_width = Font->Get_Char_Spacing (*word++);
wordCount = 0;
//Added By Saad
line_width += word_width;
}
//
Expand Down
2 changes: 1 addition & 1 deletion Core/Tools/Autorun/GameText.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@
m_munkee(FALSE),
m_noStringList(NULL),
m_useStringFile(TRUE),
m_failed(L"***FATAL*** String Manager failed to initilaized properly")
m_failed(L"***FATAL*** String Manager failed to initialized properly")
{
}

Expand Down Expand Up @@ -814,7 +814,7 @@
file.close();
}

return ok;

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 817 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)
}

//============================================================================
Expand Down Expand Up @@ -1038,7 +1038,7 @@

file.close();

return ok;

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1041 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)
}

//============================================================================
Expand Down Expand Up @@ -1114,7 +1114,7 @@

*buffer = 0;

return ok;

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build Generals / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-releaselog+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)

Check warning on line 1117 in Core/Tools/Autorun/GameText.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / vc6-profile+t+e 

 'int' : forcing value to bool 'true' or 'false' (performance warning)
}

//============================================================================
Expand Down
4 changes: 0 additions & 4 deletions Generals/Code/GameEngine/Include/Common/Geometry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,8 @@ class GeometryInfo : public Snapshot

GeometryInfo(GeometryType type, Bool isSmall, Real height, Real majorRadius, Real minorRadius)
{
// Added by Sadullah Nader
// Initializations missing and needed
m_boundingCircleRadius = 0.0f;
m_boundingSphereRadius = 0.0f;
//

set(type, isSmall, height, majorRadius, minorRadius);
}

Expand Down
4 changes: 0 additions & 4 deletions Generals/Code/GameEngine/Include/Common/INI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,8 @@ class MultiIniFieldParse
public:
MultiIniFieldParse() : m_count(0)
{
//Added By Sadullah Nader
//Initializations missing and needed
for(Int i = 0; i < MAX_MULTI_FIELDS; i++)
m_extraOffset[i] = 0;
//

}

void add(const FieldParse* f, UnsignedInt e = 0);
Expand Down
Loading
Loading