-
Notifications
You must be signed in to change notification settings - Fork 121
feat(movie): Implement ESC button mapping to skip Campaign, Challenge and Score videos #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This needs another revision. |
3ca2ff3 to
02cb634
Compare
|
Revised. I noticed there is also a movie playback in Score Screen, which apparently is used for End of Campaign videos. I made some changes to Keyboard class to allow consume raw keys from there. Tested in Campaign and Challenge. Worked. |
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ScoreScreen.cpp
Outdated
Show resolved
Hide resolved
1cbf8e4 to
5534024
Compare
Skyaero42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generals campaign video was also a loading screen. Does it work with that as well?
|
I do not understand the question. Is that unique to Generals? |
5534024 to
6b7c19f
Compare
|
Replicated in Generals with minor conflicts |
…pressed keys (#1926)
… and Score videos (#1926)
6b7c19f to
5bccbc9
Compare
I'll answer my own question, the 'satellite' video at the start of Generals missions are indeed skipable now. |
Merge with Rebase
This change implements a ESC button mapping to skip Campaign, Challenge and Score videos.
TODO