Skip to content

refactor: Remove all explicit UnicodeString instantiations from C strings #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xezon merged 1 commit into from
Nov 30, 2025
Merged

refactor: Remove all explicit UnicodeString instantiations from C strings #1928

xezon merged 1 commit into from
Nov 30, 2025

Conversation

@xezon
Copy link

@xezon xezon commented Nov 30, 2025

This change removes all explicit UnicodeString instantiations from C strings. It was applied with a script.

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing and removed Minor Severity: Minor < Major < Critical < Blocker labels Nov 30, 2025
Skyaero42
Skyaero42 approved these changes Nov 30, 2025
View reviewed changes
Copy link

@Skyaero42 Skyaero42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UnicodeString("Approved ;)")

@xezon xezon merged commit 0410990 into TheSuperHackers:main Nov 30, 2025
23 checks passed
@xezon xezon deleted the xezon/refactor-asciistring-unicodestring-instance-3 branch November 30, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skyaero42 Skyaero42 Skyaero42 approved these changes

Assignees

No one assigned

Labels

Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xezon @Skyaero42