fix(update): Fix value initialization of ProjectileStreamUpdate::m_projectileIDs

[Caball009]

This PR properly initializes ProjectileStreamUpdate::m_projectileIDs instead of a local array with the same name. This change is not user-facing because the memory allocators would still zero-initialize memory on allocation. I've also reordered the assignments to match the order of declaration.

This class is used for the GLA Toxin Tractor and USA Ambulance on the first time they fire, and on loading a save game with these units if they have fired before.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed a critical variable shadowing bug in ProjectileStreamUpdate constructor where a local array was being initialized instead of the member variable m_projectileIDs. The old code declared ObjectID m_projectileIDs[MAX_PROJECTILE_STREAM] as a local variable, shadowing the class member, which left the actual member array uninitialized.

Changes:

• Replaced manual loop with std::fill() to correctly initialize the member m_projectileIDs array with INVALID_ID
• Reordered member initialization to match declaration order in header file
• Applied identical fix to both Generals and GeneralsMD versions

Impact:
While the bug was masked in practice by zero-initialization from memory allocators, this fix eliminates undefined behavior and ensures proper initialization. Affects GLA Toxin Tractor and USA Ambulance projectile stream rendering on first fire and save game loading.

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The fix correctly addresses a variable shadowing bug by properly initializing the member array instead of a local variable. The use of std::fill is idiomatic C++, and the reordering of initialization matches the declaration order. Both files (Generals and GeneralsMD) have identical, correct fixes.
• No files require special attention

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Source/GameLogic/Object/Update/ProjectileStreamUpdate.cpp	Fixed variable shadowing bug by properly initializing member m_projectileIDs array using std::fill, and reordered member initialization to match declaration order
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/ProjectileStreamUpdate.cpp	Fixed variable shadowing bug by properly initializing member m_projectileIDs array using std::fill, and reordered member initialization to match declaration order

Sequence Diagram

sequenceDiagram
    participant Client as Game System
    participant Constructor as ProjectileStreamUpdate()
    participant Member as m_projectileIDs[20]
    
    Note over Client,Member: Before Fix - Variable Shadowing Bug
    Client->>Constructor: new ProjectileStreamUpdate()
    Constructor->>Constructor: ObjectID m_projectileIDs[20] (local)
    Constructor->>Constructor: for loop initializes local array
    Note over Constructor: Local array destroyed!
    Constructor->>Member: Member array left uninitialized
    Constructor-->>Client: Return (undefined behavior)
    
    Note over Client,Member: After Fix - Correct Initialization
    Client->>Constructor: new ProjectileStreamUpdate()
    Constructor->>Member: std::fill(m_projectileIDs, ..., INVALID_ID)
    Constructor->>Member: m_nextFreeIndex = 0
    Constructor->>Member: m_firstValidIndex = 0
    Constructor->>Member: m_owningObject = INVALID_ID
    Constructor-->>Client: Return (properly initialized)

Loading

[Mauller]

Looks good, just needs replicating