feat(gui): Add replay dates to replay list in Replay Menu

[Caball009]

This PR switches the column widths of the time and version columns for listed replays, because the latter is wider. This provides enough space to display both time and date in the second column.

We should sort the replays by date instead of name, but that's outside the scope of this PR.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Overview

Greptile Summary

Updates the replay menu to display both time and date for replay files instead of only the time. The version column and time/date column widths are swapped because the version string is wider, providing enough space to display the full date-time information without line breaks. Changes are identical in both Generals and GeneralsMD codebases as expected.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• Changes are straightforward UI improvements that display additional information (date alongside time) and adjust column widths accordingly. The implementation correctly uses existing helper functions (getUnicodeTimeBuffer and getUnicodeDateBuffer) and includes proper null-safety checks before manipulating column widths. Code is identical between Generals and GeneralsMD as required by contribution guidelines.
• No files require special attention

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp	Displays date and time in replay list, swaps column widths to accommodate longer date-time strings
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp	Displays date and time in replay list, swaps column widths to accommodate longer date-time strings

Sequence Diagram

sequenceDiagram
    participant User
    participant ReplayMenuInit
    participant ListboxData
    participant PopulateReplayFileListbox
    participant getUnicodeTimeBuffer
    participant getUnicodeDateBuffer
    participant GadgetListBoxAddEntryText

    User->>ReplayMenuInit: Initialize replay menu
    ReplayMenuInit->>ListboxData: Get listbox user data
    Note over ReplayMenuInit,ListboxData: Check if columns == 4 and<br/>columnWidth[1] < columnWidth[2]
    ReplayMenuInit->>ListboxData: Swap columnWidth[1] and columnWidth[2]
    ReplayMenuInit->>PopulateReplayFileListbox: Populate replay files
    loop For each replay file
        PopulateReplayFileListbox->>getUnicodeTimeBuffer: Get time string from header.timeVal
        getUnicodeTimeBuffer-->>PopulateReplayFileListbox: Return time string
        PopulateReplayFileListbox->>getUnicodeDateBuffer: Get date string from header.timeVal
        getUnicodeDateBuffer-->>PopulateReplayFileListbox: Return date string
        Note over PopulateReplayFileListbox: Format: "%s %s"<br/>(time + space + date)
        PopulateReplayFileListbox->>GadgetListBoxAddEntryText: Add replay name to column 0
        PopulateReplayFileListbox->>GadgetListBoxAddEntryText: Add date-time to column 1
        PopulateReplayFileListbox->>GadgetListBoxAddEntryText: Add version to column 2
        PopulateReplayFileListbox->>GadgetListBoxAddEntryText: Add map info to column 3
    end
    ReplayMenuInit-->>User: Display replay list with date and time

Loading

[xezon]

How does it look? Would it have enough room for date and time?

[Caball009]

Maybe there would be enough space for both in a single column for this resolution (1920 * 1080), but I'm not sure if that's true for all resolutions. The save games have a separate column for date and time. I'm guessing we can't just add another column without modifying the window files.

Edit: I can do some tests at different resolutions putting date and time in the same column for now.

[xezon]

Yes check how it looks. Judging by the Replay Name and Map Name columns, it looks like it is possible to set them to word wrap or not word wrap. I wonder what the time column is set to.

[Caball009]

FWIW, the version column is slightly wider than the time column. If we switch them around, there's enough space for time + date.

The only resolution that uses a line break for time + date is 800 * 600 AFAICS, otherwise it looks like this:

[xezon]

Ok it's not bad. Are we OK with changing the order? It is quite a big change. Also we need to consider, that Community Projects may write longer Version Names in there.

How does it look with time date in original column?

[Caball009]

With 24 hour format, you need at least 1366 * 768 to avoid a line break. With 12 hour format, there can be a line break even at 1920 * 1080.

1366 * 768:

1920 * 1080:

[xezon]

You can hack the Column widths in Code, then we do not need to update the WND right now.

We do have macro ENABLE_GUI_HACKS for this. Try use that to swap the width of the columns if Column 2 is smaller than Column 3.

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[xezon]

Code looks good. Needs to be replicated to Generals.

[Caball009]

Added comment and replicated in Generals.

[xezon]

Can you make a follow up change to this where you make an alternative code path for a 5th column where time and date are separated like in the saveload screen? Then a new ReplayMenu.WND edit can add the fifth column.

[Caball009]

Can you make a follow up change to this where you make an alternative code path for a 5th column where time and date are separated like in the saveload screen? Then a new ReplayMenu.WND edit can add the fifth column.

Yeah, can do that.

We anticipate 5 columns with column 2 for the time and column 3 for the date? Would it go behind ! ENABLE_GUI_HACKS?

[xezon]

Yeah, can do that.

We anticipate 5 columns with column 2 for the time and column 3 for the date? Would it go behind ! ENABLE_GUI_HACKS?

Basically if columnCount == 4 then do the current stuff, if columnCount == 5, split time and date column into 2 separate columns.