fix(netpacket): Fix misplaced null test in NetPacket::addCommand()

[xezon]

This change fixes a misplaced null test in NetPacket::addCommand().

[greptile-apps]

Greptile Overview

Greptile Summary

This PR fixes a crash bug in NetPacket::addCommand(NetCommandRef* msg) by moving the msg == nullptr guard before the first dereference (msg->getCommand()). With this change, callers can pass a null msg and the function will return success (TRUE) without accessing invalid memory.

The change is localized to the networking packet assembly path in Core/GameEngine/Source/GameNetwork/NetPacket.cpp and does not alter the command dispatch logic beyond preventing the null-pointer dereference.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk.
• The change is a minimal, correctness-only fix that prevents a definite null-pointer dereference by moving an existing null check before the first use of msg. No control-flow or data-format behavior changes occur beyond early-returning for null input, and the patch is confined to a single function.
• No files require special attention

Important Files Changed

Filename	Overview
Core/GameEngine/Source/GameNetwork/NetPacket.cpp	Moves msg null-check before dereferencing in NetPacket::addCommand(), preventing a null pointer deref.

Sequence Diagram

sequenceDiagram
  participant Caller
  participant NetPacket
  participant NetCommandRef
  participant NetCommandMsg

  Caller->>NetPacket: addCommand(msg)
  alt msg == nullptr
    NetPacket-->>Caller: return TRUE
  else msg != nullptr
    NetPacket->>NetCommandRef: getCommand()
    NetCommandRef-->>NetPacket: cmdMsg
    NetPacket->>NetCommandMsg: getNetCommandType()
    NetCommandMsg-->>NetPacket: type
    NetPacket-->>Caller: handle type in switch
  end

Loading