perf(view): Optimize and simplify camera transform update logic

[xezon]

This change optimizes and simplifies the camera transform update logic.

This ensures that the camera transform is only ever updated once a frame and not multiple times.

The performance saving is negligent.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR centralizes camera transform recomputation behind a new m_recalcCamera flag. Instead of calling setCameraTransform() immediately from multiple mutators (scroll/angle/pitch/zoom/etc.), those paths now mark the camera “dirty” and the transform is updated once at the end of W3DView::update() (or every frame when m_isCameraSlaved is enabled). It also defers the initial transform setup from init() by setting m_recalcCamera = true, ensuring the camera is initialized on the first update.

No additional merge-blocking issues were found in the changed logic beyond the already-addressed discussion about the drawable-lock path.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk.
• Changes are localized to camera transform scheduling, preserve existing update conditions, and ensure the transform is recomputed when needed via a single end-of-update call guarded by a flag.
• No files require special attention

Important Files Changed

Filename	Overview
Core/GameEngineDevice/Include/W3DDevice/GameClient/W3DView.h	Adds a member flag (m_recalcCamera) to track whether camera transform needs recomputation; no behavioral issues found.
Core/GameEngineDevice/Source/W3DDevice/GameClient/W3DView.cpp	Consolidates camera transform updates behind m_recalcCamera to ensure setCameraTransform() is called at most once per update; constructor/init/reset behavior appears consistent; no regressions found in changed logic.

Sequence Diagram

sequenceDiagram
  participant Frame as Frame loop
  participant View as W3DView
  participant Cam as m_3DCamera

  Frame->>View: stepView()
  Note over View: Updates shake offsets only

  Frame->>View: update()
  View->>View: updateCameraLock/scroll/zoom/waypoints
  Note over View: Any camera-affecting change sets m_recalcCamera=true
  alt m_recalcCamera || m_isCameraSlaved
    View->>View: setCameraTransform()
    View->>Cam: Set_Transform(...)
    View->>View: m_recalcCamera=false
  else no camera change
    Note over View: No camera transform recompute this frame
  end

  Frame->>View: draw() / render passes
  View->>Cam: Apply() / used for rendering

Loading

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[xezon]

@greptileai

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[Skyaero42]

Ok