bugfix(particlesys): Delay creation of particle emitters until postProcess

[stephanmeesters]

• Closes W3DTankDraw::createEmitters create new particle system before XFER_LOAD of TheParticleSystemManager cause save crash.. #754
• Relates to bugfix(particlesys): Restore Particle System IDs on save load before registering to ParticleSystemManager #2316

During loading a savegame, some particle systems were created before ParticleSystemManager had the opportunity to xfer-load the saved particle systems, which led to the possibility that some of these early created particle systems could be overwritten in m_systemMap of ParticleSystemManager. When that happens they would no longer reliably be able to use master/slave systems. The retail game does not use master/slave on the involved effects but it could appear as an issue with some mods (as the bug report describes too).

Misc findings

W3DTankDraw and W3DTankTruckDraw would create particle systems in the constructor, only to purge and recreate them again in postProcess, this has been changed to look if we're loading a savegame and then only create it once.

GrantStealthBehavior triggers when you do a GPS scrambler, but the behavior and associated particle effect will only last for one frame. The particle effect references a texture that's available in Generals but not in Zero Hour. So I think that so far nobody has been able to see this particle effect in action.

Todo

• Replicate in Generals

[greptile-apps]

Greptile Summary

Fixes particle system corruption during savegame loading by deferring emitter creation until postProcess. Previously, particle systems created in constructors could be overwritten in ParticleSystemManager::m_systemMap before saved systems were loaded, breaking master/slave relationships in mods.

Key changes:

• W3DTankDraw and W3DTankTruckDraw: Conditional emitter creation in constructor, removed redundant toss/recreate in postProcess
• AutoHealBehavior and GrantStealthBehavior: Extracted emitter creation into new createEmitters() helper with double-creation guard
• All changes check TheGameState->isInLoadGame() to defer creation during load
• The new createEmitters() methods check m_radiusParticleSystemID == INVALID_PARTICLE_SYSTEM_ID before creating, addressing previous review feedback

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix addresses a well-understood race condition with a clean architectural solution. All emitter creation is now properly guarded against double-creation, and the deferred initialization pattern is consistently applied across all affected modules. The changes eliminate wasteful toss/recreate cycles and follow the existing codebase patterns (e.g., W3DTankDraw::createTreadEmitters already checks for INVALID_PARTICLE_SYSTEM_ID).
• No files require special attention

Important Files Changed

Filename	Overview
Core/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DTankDraw.cpp	Delays tread emitter creation during savegame load, removes redundant toss/recreate in postProcess
Core/GameEngineDevice/Source/W3DDevice/GameClient/Drawable/Draw/W3DTankTruckDraw.cpp	Delays tread emitter creation during savegame load, removes redundant toss/recreate in postProcess
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/AutoHealBehavior.cpp	Implements deferred particle system creation with double-creation guard in new createEmitters() method
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Behavior/GrantStealthBehavior.cpp	Implements deferred particle system creation with double-creation guard in new createEmitters() method

_{Last reviewed commit: 8ada250}

[greptile-apps]

_{6 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{6 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}