tweak(random): Replace InitGameLogicRandom with InitRandom for consistent client and audio seeds

[Caball009]

• Follow-up PR for bugfix(skirmish): Prevent mismatch in Replay playback by restoring correct game seed after restarting a Skirmish game #2270

This PR removes function InitGameLogicRandom, and changes all use cases to InitRandom. The former only sets the logical seed values (important for the CRC), while the latter also sets the client and audio seed values. I think setting all 3 types of seed values improves consistency. This change is not user-facing.

I checked 2000+ of Joker's (short) replays and this change did not introduce any new mismatches, as expected.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Summary

This PR successfully removes the InitGameLogicRandom function and replaces all use cases with InitRandom to ensure consistent initialization of all three random seed types (logic, client, and audio). The changes are well-contained and properly update all modified files:

• Removed function declaration and implementation from RandomValue.h/cpp
• Updated calls in network callbacks (StagingRoomGameInfo.cpp, LANAPICallbacks.cpp)
• Updated calls in GUI callbacks across both Generals and GeneralsMD directories
• Cleaned up obsolete commented-out code referencing the old function

The author verified no new replay mismatches were introduced across 2000+ replays, demonstrating the change maintains deterministic behavior.

Confidence Score: 5/5

• Safe to merge once the previously flagged compilation issue is resolved
• Clean refactoring with consistent replacements across all modified files, verified with 2000+ replay tests. The previous review already identified the remaining issue in GameSpyGameInfo.cpp files.
• As noted in previous review, Generals/Code/GameEngine/Source/GameNetwork/GameSpyGameInfo.cpp and GeneralsMD/Code/GameEngine/Source/GameNetwork/GameSpyGameInfo.cpp still reference InitGameLogicRandom

Important Files Changed

Filename	Overview
Core/GameEngine/Include/Common/RandomValue.h	Removed InitGameLogicRandom function declaration
Core/GameEngine/Source/Common/RandomValue.cpp	Removed InitGameLogicRandom function implementation (16 lines)
Core/GameEngine/Source/GameNetwork/GameSpy/StagingRoomGameInfo.cpp	Replaced InitGameLogicRandom with InitRandom for seed initialization
Core/GameEngine/Source/GameNetwork/LANAPICallbacks.cpp	Replaced InitGameLogicRandom with InitRandom for seed initialization
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/SkirmishGameOptionsMenu.cpp	Replaced two InitGameLogicRandom calls with InitRandom for skirmish and single-player modes
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/SkirmishGameOptionsMenu.cpp	Replaced two InitGameLogicRandom calls with InitRandom for skirmish and single-player modes

_{Last reviewed commit: a7ba441}

[greptile-apps]

_{8 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (1)

GeneralsMD/Code/GameEngine/Source/GameNetwork/GameSpyGameInfo.cpp
This file still calls InitGameLogicRandom which was removed in this PR, causing a compilation error

		InitRandom( TheGameSpyGame->getSeed() );
		DEBUG_LOG(("InitRandom( %d )", TheGameSpyGame->getSeed()));

Prompt To Fix With AI

This is a comment left during a code review.
Path: GeneralsMD/Code/GameEngine/Source/GameNetwork/GameSpyGameInfo.cpp
Line: 566-567

Comment:
This file still calls `InitGameLogicRandom` which was removed in this PR, causing a compilation error

```suggestion
		InitRandom( TheGameSpyGame->getSeed() );
		DEBUG_LOG(("InitRandom( %d )", TheGameSpyGame->getSeed()));
```

How can I resolve this? If you propose a fix, please make it concise.

[Mauller]

Broke da build! but looks like it's due to core files being altered :P

[Caball009]

Yes, Generals isn't updated yet but the core files are, so that project won't compile.

[greptile-apps]

_{8 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[xezon]

I think setting all 3 types of seed values improves consistency

So if I understand this correctly, then this means Client and Audio now also have random seeding on every match start, whereas before they just kept evolving from match to match? Could there be any reason why EA chose to do that intentionally?

[xezon]

I do not know what this is good for but looks okay anyway. Needs Rebase and Replicate.

[Caball009]

So if I understand this correctly, then this means Client and Audio now also have random seeding on every match start, whereas before they just kept evolving from match to match?

Yes.

Could there be any reason why EA chose to do that intentionally?

Not that I can see. If you check the code for the replays, you can see that they started to use InitRandom. That makes me more confident that we should also do that for live games.

I do not know what this is good for but looks okay anyway. Needs Rebase and Replicate.

Will update later.