refactor: Simplify unconditional asserts from DEBUG_ASSERTCRASH to DEBUG_CRASH

[Caball009]

This PR changes occurrences such as DEBUG_ASSERTCRASH(FALSE, ("")) to DEBUG_CRASH(("")).

I used regex search and replace in VS22 with
from: DEBUG_ASSERTCRASH( *)\(( *)FALSE *, * (case insensitive)
to: DEBUG_CRASH$1($2

Edit: DEBUG_ASSERTCRASH( 0, ...) is now also included.

[greptile-apps]

Greptile Summary

Refactored unconditional debug assertions to use the more semantically appropriate DEBUG_CRASH macro across 89 files.

• Replaced all instances of DEBUG_ASSERTCRASH(FALSE, (...)), DEBUG_ASSERTCRASH(0, (...)), and DEBUG_ASSERTCRASH(false, (...)) with DEBUG_CRASH((...))
• The transformation is semantically correct: since DEBUG_ASSERTCRASH(condition, message) only crashes when the condition is false, passing FALSE/0/false makes it an unconditional crash, which is exactly what DEBUG_CRASH does
• Applied via regex search-and-replace in VS22 with pattern DEBUG_ASSERTCRASH( *)\(( *)FALSE *, * → DEBUG_CRASH$1($2 (case insensitive)
• Total of 205 replacements across Core, Generals, and GeneralsMD directories
• No logic changes, only improved code clarity by using the correct macro for unconditional crashes
• Spacing and formatting preserved correctly in all replacements

Confidence Score: 5/5

• This PR is safe to merge with no risk
• Purely mechanical refactoring with no behavioral changes. The transformation is semantically identical (unconditional assertions converted to unconditional crashes). All 205 replacements follow the same pattern and preserve existing functionality. No code logic, error handling, or program flow affected.
• No files require special attention

Important Files Changed

Filename	Overview
Core/GameEngine/Source/Common/INI/INI.cpp	Replaced 7 unconditional assertions with DEBUG_CRASH for error handling
Core/GameEngine/Source/GameClient/GameText.cpp	Replaced 12 unconditional assertions with DEBUG_CRASH for error handling
Generals/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBarScheme.cpp	Replaced 15 unconditional assertions with DEBUG_CRASH for validation checks
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/ControlBar/ControlBarScheme.cpp	Replaced 15 unconditional assertions with DEBUG_CRASH for validation checks
Generals/Code/GameEngine/Source/GameClient/GUI/GameWindowTransitionsStyles.cpp	Replaced 15 unconditional assertions with DEBUG_CRASH
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GameWindowTransitionsStyles.cpp	Replaced 15 unconditional assertions with DEBUG_CRASH

_{Last reviewed commit: cd5a821}

[xezon]

Nice. While at it, also fix the DEBUG_ASSERTCRASH( 0, ...)

[Caball009]

Nice. While at it, also fix the DEBUG_ASSERTCRASH( 0, ...)

Ah, I hadn't noticed those. I just changed them.

[xezon]

Looking good.

[Skyaero42]

Agreed, this looks good.