Skip to content

refactor: Remove redundant void argument from functions#2345

Merged
xezon merged 5 commits intoTheSuperHackers:mainfrom
bobtista:bobtista/clang-tidy-modernize-redundant-void-arg
Feb 24, 2026
Merged

refactor: Remove redundant void argument from functions#2345
xezon merged 5 commits intoTheSuperHackers:mainfrom
bobtista:bobtista/clang-tidy-modernize-redundant-void-arg

Conversation

@bobtista
Copy link

@bobtista bobtista commented Feb 24, 2026

Summary

  • Remove redundant void parameter from function declarations and definitions, e.g. f(void)f()
  • Applied using clang-tidy modernize-redundant-void-arg check across the full codebase (excluding Tools)

@greptile-apps
Copy link

greptile-apps bot commented Feb 24, 2026

Too many files changed for review. (2066 files found, 500 file limit)

@Stubbjax
Copy link

It would be great if f( void ) became f() instead of f( ).

There are also many places that are not covered as expected, such as GameWindow.h. Searching using regex (\b *)\(+ *void *\)+\B yields a further 1,091 results (excluding Tools).

@bobtista
Copy link
Author

It would be great if f( void ) became f() instead of f( ).

There are also many places that are not covered as expected, such as GameWindow.h. Searching using regex (\b *)\(+ *void *\)+\B yields a further 1,091 results (excluding Tools).

added new commits for each, using regex to apply them

@xezon xezon added Major Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing labels Feb 24, 2026
Copy link

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very welcome. This void is so annoying. Too big to inspect. Will cause conflicts on existing pulls.

@xezon xezon changed the title refactor: Remove redundant void parameter from function declarations refactor: Remove superfluous single void argument from functions Feb 24, 2026
@xezon xezon changed the title refactor: Remove superfluous single void argument from functions refactor: Remove redundant void argument from functions Feb 24, 2026
@xezon xezon merged commit 78d94fb into TheSuperHackers:main Feb 24, 2026
25 checks passed
CookieLandProjects pushed a commit to CookieLandProjects/CLP_AI that referenced this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Major Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants