Skip to content

style: Convert continuation lines to tabs in Generals#2571

Open
bobtista wants to merge 8 commits intoTheSuperHackers:mainfrom
bobtista:bobtista/feat/continuation-indent-generals
Open

style: Convert continuation lines to tabs in Generals#2571
bobtista wants to merge 8 commits intoTheSuperHackers:mainfrom
bobtista:bobtista/feat/continuation-indent-generals

Conversation

@bobtista
Copy link
Copy Markdown

@bobtista bobtista commented Apr 9, 2026

Summary

  • Convert continuation lines (multi-line function args, initializer lists, etc.) to tabs
  • Continuation lines get parent statement depth + 1 tab
  • Closing delimiters on their own line go at parent depth
  • All changes are whitespace-only (git diff -w is empty)

Note on diff size

This PR currently shows a large diff because it includes Phase 1-3 changes
(#2561-#2564) in its branch history. After those PRs merge and this is
rebased onto main, the diff will shrink to just the continuation line delta.

Both parts

Script

The formatting script is included for reference. See scripts/cpp/convert_leading_spaces_to_tabs.py.

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Apr 9, 2026

Too many files changed for review. (545 files found, 500 file limit)

@bobtista
Copy link
Copy Markdown
Author

bobtista commented Apr 9, 2026

These should be rebased after 2561-2564 get merged, as they contain those changes. I couldn't set the base branch in github here because those branches only exist on my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant