refactor: Remove superfluous returns at the end of functions

[xezon]

• Fixes Remove unnecessary return statements at function end #1778

This change removes superfluous returns at the end of functions.

Applied with python script and a bit of hand holding.

[greptile-apps]

Greptile Summary

This PR performs a mechanical, codebase-wide style cleanup by removing superfluous return; statements at the end of void functions across 194 C++ source files, along with the Python script (scripts/cpp/remove_return.py) used to apply the changes. No logic is altered — every removed return was a no-op at the end of a function body.

Confidence Score: 5/5

Safe to merge — purely cosmetic refactoring with no behavioral changes.

All 195 changed files only remove trailing return; or return ; statements that were no-ops at the end of void functions. The driving script correctly gates removal on the closing brace being at column 0 (function-level brace), making false-positive removals of non-superfluous returns effectively impossible with typical indentation. The sole finding is a P2 style note about the script's own trailing return.

No files require special attention.

Important Files Changed

Filename	Overview
scripts/cpp/remove_return.py	New helper script that drives the mass refactoring; logic is sound but contains a superfluous return at the end of its own main().
Core/GameEngine/Source/GameClient/GUI/GameWindow.cpp	Removes two trailing return; statements from empty void stubs — correct and safe.
Core/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp	Removes four trailing return ; statements from void methods; no logic change.
Core/Libraries/Source/WWVegas/WWLib/wwstring.h	Removes multiple trailing return ; statements from inline constructors and helpers in the header — all correctly identified as superfluous.
Generals/Code/GameEngine/Source/GameLogic/AI/AIPlayer.cpp	Single return; removal from buildUpgrade; straightforward and correct.
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/SpectreGunshipUpdate.cpp	Removes trailing return; and its preceding blank line from disengageAndDepartAO; correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[remove_return.py] --> B[Glob cpp/h/inl files across Core, Generals, GeneralsMD]
    B --> C{For each line}
    C --> D{Starts with return-semicolon?}
    D -- No --> E[Keep line as-is]
    D -- Yes --> F{Next non-blank line starts with closing-brace at column 0?}
    F -- No --> E
    F -- Yes --> G[Remove return line and preceding blank lines]
    G --> H[Write cleaned file]
    E --> H

Loading

Prompt To Fix All With AI

This is a comment left during a code review.
Path: scripts/cpp/remove_return.py
Line: 63

Comment:
**Superfluous `return` in the script itself**

The script that removes superfluous `return` statements at the end of functions itself contains one at the end of `main()`. Since the script only processes C++ files it won't self-apply, but it's a minor irony worth noting.

```suggestion
    main()
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (2): Last reviewed commit: "Remove a few more" | Re-trigger Greptile}

[Caball009]

Do you plan to get rid of the now empty lines as well?

[xezon]

The script only removed empty lines above the return. Not below. I think it is fine.

[Skyaero42]

I agree the extra lines are fine. Based on a small sample it seems to fit in the style of the respective file anyways.