You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds one space to the padding in the four sprintf continuation lines inside saveComboBoxData so that MAXCHARS, MAXDISPLAY, ASCIIONLY, and LETTERSANDNUMBERS correctly align with ISEDITABLE (after the 15-character COMBOBOXDATA = prefix) in saved WND files. The fix is applied identically in both the Generals/ and GeneralsMD/ copies of Save.cpp.
Confidence Score: 5/5
Safe to merge — minimal, correct alignment-only change with no logic impact.
The change is a single-character padding correction applied consistently to both Generals/ and GeneralsMD/ files. The arithmetic is correct (15 chars for COMBOBOXDATA = ), no logic is altered, and there are no P0/P1 findings.
No files require special attention.
Important Files Changed
Filename
Overview
Generals/Code/Tools/GUIEdit/Source/Save.cpp
Corrects continuation-line padding from 14 to 15 spaces in saveComboBoxData so MAXCHARS/MAXDISPLAY/ASCIIONLY/LETTERSANDNUMBERS align with ISEDITABLE in the WND file output.
GeneralsMD/Code/Tools/GUIEdit/Source/Save.cpp
Identical alignment fix as Generals counterpart — one extra space added to the four continuation-line literals in saveComboBoxData.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinorSeverity: Minor < Major < Critical < BlockerToolsAffects Tools only
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an indentation issue when saving WND files, thus preventing new indentation issues in TheSuperHackers/GeneralsGamePatch2#12
There is still a problem that when saving the file, the fonts defined in the file are overwritten