Skip to content

style(guiedit): Adjust indentation for combo box data output in save function#2625

Merged
xezon merged 1 commit intoTheSuperHackers:mainfrom
DevGeniusCode:guiedit
Apr 18, 2026
Merged

style(guiedit): Adjust indentation for combo box data output in save function#2625
xezon merged 1 commit intoTheSuperHackers:mainfrom
DevGeniusCode:guiedit

Conversation

@DevGeniusCode
Copy link
Copy Markdown

@DevGeniusCode DevGeniusCode commented Apr 18, 2026

This PR fixes an indentation issue when saving WND files, thus preventing new indentation issues in TheSuperHackers/GeneralsGamePatch2#12

There is still a problem that when saving the file, the fonts defined in the file are overwritten

@DevGeniusCode DevGeniusCode added Minor Severity: Minor < Major < Critical < Blocker Tools Affects Tools only labels Apr 18, 2026
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 18, 2026

Greptile Summary

Adds one space to the padding in the four sprintf continuation lines inside saveComboBoxData so that MAXCHARS, MAXDISPLAY, ASCIIONLY, and LETTERSANDNUMBERS correctly align with ISEDITABLE (after the 15-character COMBOBOXDATA = prefix) in saved WND files. The fix is applied identically in both the Generals/ and GeneralsMD/ copies of Save.cpp.

Confidence Score: 5/5

Safe to merge — minimal, correct alignment-only change with no logic impact.

The change is a single-character padding correction applied consistently to both Generals/ and GeneralsMD/ files. The arithmetic is correct (15 chars for COMBOBOXDATA = ), no logic is altered, and there are no P0/P1 findings.

No files require special attention.

Important Files Changed

Filename Overview
Generals/Code/Tools/GUIEdit/Source/Save.cpp Corrects continuation-line padding from 14 to 15 spaces in saveComboBoxData so MAXCHARS/MAXDISPLAY/ASCIIONLY/LETTERSANDNUMBERS align with ISEDITABLE in the WND file output.
GeneralsMD/Code/Tools/GUIEdit/Source/Save.cpp Identical alignment fix as Generals counterpart — one extra space added to the four continuation-line literals in saveComboBoxData.

Reviews (1): Last reviewed commit: "style(guiedit): Adjust indentation for c..." | Re-trigger Greptile

@xezon xezon merged commit aa2b09d into TheSuperHackers:main Apr 18, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Severity: Minor < Major < Critical < Blocker Tools Affects Tools only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants