tweak(gamemessage): Remove unused argument of MSG_DESTROY_SELECTED_GROUP

[Caball009]

This PR makes a small tweak to GameMessage::MSG_DESTROY_SELECTED_GROUP. It had an unused boolean argument, but it's called many times; on every left mouse click that's not on the HUD, actually. The removal should provide a modest reduction in the number of bytes that are stored in replays or sent across the network.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Summary

This PR removes an unused boolean argument from GameMessage::MSG_DESTROY_SELECTED_GROUP in both the Generals and GeneralsMD codebases, and updates the corresponding header comment to better describe the message's actual behavior. All message handlers (GameLogicDispatch.cpp, CommandXlat.cpp) were verified to not consume any argument from this message, confirming the boolean was dead data.

The PR description's TODO "Replicate in Generals" appears to be a stale checkbox — the Generals changes are already included in this PR.

Confidence Score: 5/5

Safe to merge — the boolean argument was confirmed unused across all message handlers in both codebases.

All handlers for MSG_DESTROY_SELECTED_GROUP were verified to not read any argument, the change is applied symmetrically across Generals and GeneralsMD, and the updated doc comment is more accurate than the original.

No files require special attention.

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Include/Common/MessageStream.h	Updates the MSG_DESTROY_SELECTED_GROUP doc comment from the inaccurate (teamID) description to a clearer behavioral description.
Generals/Code/GameEngine/Source/GameClient/InGameUI.cpp	Removes the unused appendBooleanArgument(true) call and its misleading comment; adds a @tweak note explaining the rationale.
GeneralsMD/Code/GameEngine/Include/Common/MessageStream.h	Mirror of the Generals header change — same doc comment correction for MSG_DESTROY_SELECTED_GROUP.
GeneralsMD/Code/GameEngine/Source/GameClient/InGameUI.cpp	Mirror of the Generals source change — removes the dead boolean argument and adds the explanatory @tweak comment.

Sequence Diagram

sequenceDiagram
    participant UI as InGameUI
    participant MS as TheMessageStream
    participant CX as CommandXlat
    participant GLD as GameLogicDispatch

    UI->>MS: appendMessage(MSG_DESTROY_SELECTED_GROUP)
    Note over UI,MS: Before: also appended boolean true (unused)
    MS->>CX: dispatch MSG_DESTROY_SELECTED_GROUP
    CX->>CX: m_teamExists = false
    MS->>GLD: dispatch MSG_DESTROY_SELECTED_GROUP
    GLD->>GLD: setCurrentlySelectedAIGroup(nullptr)

Loading

_{Reviews (2): Last reviewed commit: "Replicated in Generals." | Re-trigger Greptile}

[Caball009]

Replicated in Generals.

FWIW, I probably have two more PRs coming up that make similar changes.