chore(player): Remove unused GameMessage argument from Player member functions

[Caball009]

This PR removes unused function parameter GameMessage* msg from functions Player::processSelectTeamGameMessage and Player::processAddTeamGameMessage.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Summary

Removes the unused GameMessage* msg parameter from Player::processSelectTeamGameMessage and Player::processAddTeamGameMessage in both Generals/ and GeneralsMD/ codebases. The parameter was passed at the call sites in GameLogicDispatch.cpp but never read inside the function bodies, so its removal is correct and complete across declarations, definitions, and call sites.

Confidence Score: 5/5

Safe to merge — mechanical parameter removal with no logic changes.

All six changed files are consistent: declarations, definitions, and call sites are updated in lock-step for both Generals and GeneralsMD. The removed parameter was provably unused in both function bodies. No logic, data flow, or behaviour is altered.

No files require special attention.

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Include/Common/Player.h	Declarations of processSelectTeamGameMessage and processAddTeamGameMessage updated to drop the unused GameMessage* parameter.
Generals/Code/GameEngine/Source/Common/RTS/Player.cpp	Definitions of both functions updated to match the new signatures; parameter was confirmed unused inside both bodies.
Generals/Code/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp	Call sites updated to omit the msg argument; surrounding dispatch logic is unchanged.
GeneralsMD/Code/GameEngine/Include/Common/Player.h	Zero Hour counterpart declarations updated identically to the Generals/ header.
GeneralsMD/Code/GameEngine/Source/Common/RTS/Player.cpp	Zero Hour counterpart definitions updated; both function bodies confirmed not to use the removed parameter.
GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp	Zero Hour call sites updated to omit the msg argument; no other logic changes.

Sequence Diagram

sequenceDiagram
    participant GLD as GameLogicDispatch
    participant P as Player

    Note over GLD,P: Before PR
    GLD->>P: processSelectTeamGameMessage(hotkeyNum, msg)
    GLD->>P: processAddTeamGameMessage(hotkeyNum, msg)

    Note over GLD,P: After PR
    GLD->>P: processSelectTeamGameMessage(hotkeyNum)
    GLD->>P: processAddTeamGameMessage(hotkeyNum)

Loading

_{Reviews (2): Last reviewed commit: "Replicated in Generals." | Re-trigger Greptile}

[Caball009]

Replicated in Generals.