feat(math): Route game logic math through WWMath with 3-mode deterministic support

[Okladnoj]

Rework of #2602, incorporating review feedback:

• GameMath via FetchContent (per @stephanmeesters, @OmniBlade recommendation)
• Trig.cpp preserved, redirected to WWMath instead of deleted (per @xezon request for standalone change)
• 3 math modes: VC6 (x87 inline asm), CRT (standard library), GameMath deterministic (per @Mauller recommendation)
• USE_DETERMINISTIC_MATH unconditional for non-VC6 — missing gmath.h is now a compile error instead of silent fallback to x87/CRT
• Clean history from main

CI: win32 + vc6 ✅, replay checks ✅

Open question: Replay checks pass both with and without USE_DETERMINISTIC_MATH, even though golden replays were recorded with an x87 build. The replays may not contain MSG_LOGIC_CRC messages, meaning the check only validates absence of crashes rather than game state CRC parity. If anyone has insight on this — please share.

[greptile-apps]

Greptile Summary

This PR routes all game-logic math calls through WWMath with three modes: VC6 x87 inline assembly (unchanged), CRT standard library (non-deterministic fallback), and GameMath deterministic (default for all non-VC6 builds). The change is a large but mostly mechanical replacement of raw sqrt/fabs/atan2/sinf etc. calls with WWMath::*Origin and WWMath::*Trig wrappers across 84 files in both Generals/ and GeneralsMD/, with GameMath pulled via FetchContent at a pinned commit.

Confidence Score: 4/5

Safe to merge after verifying the global include_directories concern; the mechanical call-site changes are consistently applied and CI passes.

No P0 findings. One P2 style issue (global include_directories CMake anti-pattern) is present; prior-thread P1 items (USE_DETERMINISTIC_MATH/gmath.h decoupling, double-to-float narrowing, incomplete CRC routing) are already noted and partially addressed. The mass call-site migration is consistent and correct.

cmake/gamemath.cmake (global include_directories), Core/Libraries/Source/WWVegas/WWMath/wwmath.h (USE_DETERMINISTIC_MATH/gmath.h coupling and double wrappers, per prior threads)

Important Files Changed

Filename	Overview
Core/Libraries/Source/WWVegas/WWMath/wwmath.h	Core of the PR: adds USE_DETERMINISTIC_MATH block and ~80 new Origin/Trig inline wrappers over GameMath gm_* functions; USE_DETERMINISTIC_MATH is defined unconditionally for non-VC6 regardless of whether gmath.h was found (discussed in prior threads), and double overloads silently narrow to float before calling gm_*f (also in prior threads).
cmake/gamemath.cmake	New CMake module: fetches GameMath at a pinned commit, disables intrinsics/tests with FORCE overrides, and adds a global include_directories for gmath.h — a CMake anti-pattern that could cause silent link failures in targets that include wwmath.h without linking gamemath.
Core/GameEngine/Source/Common/Diagnostic/SimulationMathCrc.cpp	Math CRC fingerprint updated to use WWMath Origin wrappers; remaining raw CRT calls (tanf/asinf/acosf) replaced with deterministic equivalents per prior thread; sinhf/coshf/tanhf/logf wrappers now go through GameMath equivalents.
Core/Libraries/Include/Lib/BaseType.h	sqrt → Sqrt migration in Coord2D/Coord3D/ICoord2D/ICoord3D length() methods; changes are mechanical and correct.
Core/Libraries/Include/Lib/trig.h	Adds double Sqrt(double x) declaration to the global trig helper header; consistent with the new Trig.cpp implementation that routes through WWMath::SqrtOrigin.
Core/Libraries/Source/WWVegas/WWMath/CMakeLists.txt	Links gamemath as a PUBLIC dependency of core_wwmath for non-VC6 builds, ensuring transitive propagation to downstream targets.
Generals/Code/GameEngine/Source/Common/System/Trig.cpp	All five trig functions redirected to WWMath::*Trig wrappers; new double Sqrt(double) added that routes through SqrtOrigin.
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/PhysicsUpdate.cpp	Comprehensive routing of fabs/sqrtf/atan2/fabsf calls to WWMath Origin wrappers in physics simulation — mechanical and consistent.
CMakeLists.txt	Includes gamemath.cmake for non-VC6 builds via a conditional include block; minimal and correct.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Math call site\ne.g. sqrtf / fabs / atan2] --> B{Compiler target?}
    B -- VC6\n_MSC_VER < 1300 --> C[x87 inline ASM\noriginal WWMath]
    B -- Non-VC6 --> D{USE_DETERMINISTIC_MATH\nalways defined}
    D -- gmath.h found\nvia global include_dirs --> E[GameMath gm_*f\ncross-platform deterministic]
    D -- gmath.h NOT found\nlinker error --> F[Link failure\nunresolved gm_* symbols]
    E --> G[WWMath::*Origin / *Trig\ninline wrappers in wwmath.h]
    G --> H[Game logic\nsimulation result]
    C --> H

Loading

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
cmake/gamemath.cmake:14-16
**Global `include_directories` pollutes all target include paths**

`include_directories()` is a directory-scope CMake command that injects `${gamemath_SOURCE_DIR}/include` into every target compiled under this directory. Combined with `USE_DETERMINISTIC_MATH` being unconditionally defined on non-VC6, any target that transitively includes `wwmath.h` but does **not** link `core_wwmath` (or `gamemath` directly) will compile cleanly (because `gmath.h` is now found globally) but fail at link time with unresolved `gm_*` symbols. The comment acknowledges the intent, but the modern CMake idiom — `target_include_directories(core_wwmath PUBLIC ${gamemath_SOURCE_DIR}/include)` — achieves the same ODR-safe propagation to all downstream consumers of `core_wwmath` without silently affecting unrelated targets.

_{Reviews (3): Last reviewed commit: "fix(math): Restore original formatting a..." | Re-trigger Greptile}

[Okladnoj]

Here is what replay playback looks like at the moment.

I’m testing this on a separate branch:
https://github.com/Okladnoj/GeneralsGameCode/okji/test/deterministic-math-v2

I slightly adjusted the CI there so I can run Win32 and get access to the game resources.

[Skyaero42]

You did not review the changes you made with AI. It has issues that you should fix before asking it to be reviewed.

[Okladnoj]

reviwed all changes