chore(gamemessage): Clean up GameMessage::getCommandTypeAsString

[Caball009]

This PR cleans up the switch statement in GameMessage::getCommandTypeAsString to make it exactly like the GameMessage enum.

Checks commits for clean diff.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Summary

This PR aligns the getCommandTypeAsString switch statement in both Generals and GeneralsMD MessageStream.cpp files with their respective GameMessage::Type enum definitions, correcting the order of entries, adding previously missing case labels, consolidating scattered #ifdef ALLOW_SURRENDER blocks, and cleaning up #endif// comment style.

• Generals: Adds MSG_IMPOSSIBLE_ATTACK_HINT, MSG_DO_SPECIAL_POWER_OVERRIDE_DESTINATION_HINT, MSG_DO_SPECIAL_POWER_OVERRIDE_DESTINATION, MSG_SET_MINE_CLEARING_DETAIL, and MSG_BEGIN_DEBUG_NETWORK_MESSAGES; repositions MSG_DO_ATTACK_OBJECT_AFTER_MOVING_HINT and MSG_HACK_HINT; and consolidates the three ALLOW_SURRENDER network-message case labels into one block.
• GeneralsMD: Applies the same changes plus moves the fast-forward/pause/step-frame meta messages to their correct enum position, adds MSG_ENABLE_RETALIATION_MODE, and corrects the debug-network guard from #if defined(RTS_DEBUG) to #if defined(RTS_DEBUG) || defined(_ALLOW_DEBUG_CHEATS_IN_RELEASE) to match the header enum.

Confidence Score: 5/5

This PR is safe to merge; it only touches a debug/logging string function and carries no runtime risk.

The changes are purely additive and reordering within a read-only string-lookup function. Every added case label corresponds to an enum value already present in the respective header, and the consolidation of ALLOW_SURRENDER guards is a straightforward grouping of pre-existing code. There is no logic, serialization, or network behaviour affected.

No files require special attention.

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Source/Common/MessageStream.cpp	Switch statement cleaned up to match enum order; missing case labels added and ALLOW_SURRENDER blocks consolidated. Changes are correct relative to the Generals header enum.
GeneralsMD/Code/GameEngine/Source/Common/MessageStream.cpp	Switch statement fully re-synced with the ZH enum: fast-forward/pause messages moved earlier, ALLOW_SURRENDER consolidated, MSG_ENABLE_RETALIATION_MODE added, and debug-network guard extended to include _ALLOW_DEBUG_CHEATS_IN_RELEASE.

_{Reviews (4): Last reviewed commit: "Replicated in Generals (manually)." | Re-trigger Greptile}

[xezon]

Makes sense for the most part.

[xezon]

They are referenced in GameLogicDispatch.cpp and CommandXlat.cpp however. Maybe add the enum values instead?

[Caball009]

These look like network messages, though. They can't be behind a macro, and I'm also reluctant to add them without a macro.

I could just keep them in the switch statement and leave it for another time.

[xezon]

They can just be treated like any other META message

[Caball009]

META indicates Client side only, and these are Logic messages. I've put them back in.

[Caball009]

Replicated in Generals by hand.

Gen code is now the same except for 28 ZH specific enum values (and _ALLOW_DEBUG_CHEATS_IN_RELEASE macro):

MSG_META_TOGGLE_CAMERA_TRACKING_DRAWABLE

MSG_CHEAT_RUNSCRIPT1
MSG_CHEAT_RUNSCRIPT2
MSG_CHEAT_RUNSCRIPT3
MSG_CHEAT_RUNSCRIPT4
MSG_CHEAT_RUNSCRIPT5
MSG_CHEAT_RUNSCRIPT6
MSG_CHEAT_RUNSCRIPT7
MSG_CHEAT_RUNSCRIPT8
MSG_CHEAT_RUNSCRIPT9
MSG_CHEAT_TOGGLE_SPECIAL_POWER_DELAYS
MSG_CHEAT_SWITCH_TEAMS
MSG_CHEAT_KILL_SELECTION
MSG_CHEAT_TOGGLE_HAND_OF_GOD_MODE
MSG_CHEAT_INSTANT_BUILD
MSG_CHEAT_DESHROUD
MSG_CHEAT_ADD_CASH
MSG_CHEAT_GIVE_ALL_SCIENCES
MSG_CHEAT_GIVE_SCIENCEPURCHASEPOINTS
MSG_CHEAT_SHOW_HEALTH
MSG_CHEAT_TOGGLE_MESSAGE_TEXT

MSG_META_DEBUG_SHOW_AUDIO_LOCATIONS

MSG_META_DEMO_TOGGLE_SUPPLY_CENTER_PLACEMENT

MSG_META_DEBUG_OBJECT_ID_PERFORMANCE
MSG_META_DEBUG_DRAWABLE_ID_PERFORMANCE
MSG_META_DEBUG_SLEEPY_UPDATE_PERFORMANCE

MSG_SABOTAGE_HINT

MSG_ENABLE_RETALIATION_MODE