refactor(metaevent): Split MetaEventTranslator::translateGameMessage() into smaller functions

[xezon]

• Follow up for fix(metaevent): Ignore order in which modifier keys are released to trigger meta events #2577

This change splits MetaEventTranslator::translateGameMessage() into smaller functions for better maintainability.

Logically it should function the same.

TODO

• Replicate in Generals

[greptile-apps]

Greptile Summary

This PR refactors MetaEventTranslator::translateGameMessage() in both the Generals and GeneralsMD codebases by extracting its body into six private helper methods (onMouseEvent, onKeyEvent, onKeyModStateRemoved, onKeyPressed, getActionKeyType, getKeyModState), addressing a previous review that flagged the methods as incorrectly public.

• Key event path is split into onKeyEvent → either onKeyModStateRemoved (modifier-key release) or onKeyPressed (regular key action), with getActionKeyType and getKeyModState as pure extractors.
• Mouse event path is moved verbatim into onMouseEvent; no logic changes.
• Both Generals and GeneralsMD receive identical refactors.

Confidence Score: 5/5

Pure refactor — no observable behavior changes; safe to merge.

Every branch of the original translateGameMessage is preserved verbatim in the extracted helpers. The modifier-key state tracking, meta-map matching, mouse click synthesis, and the fast-forward-replay special case all produce the same side effects and disp value as before. The previously reported public visibility issue is fixed, and the KEY_STATE_DOWN flag vs. message-type question was explained and is sound.

No files require special attention.

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Include/GameClient/MetaEvent.h	Adds six new private helper method declarations to MetaEventTranslator; correctly placed in private: section.
Generals/Code/GameEngine/Source/GameClient/MessageStream/MetaEvent.cpp	Extracts translateGameMessage body into five helper methods; logic appears equivalent to the original, with improved readability and consistent indentation.
GeneralsMD/Code/GameEngine/Include/GameClient/MetaEvent.h	Mirror of the Generals header change; six new private helper declarations added correctly.
GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/MetaEvent.cpp	Identical refactor to the Generals counterpart; same helper extraction with equivalent logic.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[translateGameMessage] --> B{message type?}
    B -- MSG_RAW_KEY_DOWN or MSG_RAW_KEY_UP --> C[onKeyEvent]
    B -- MSG_RAW_MOUSE_BEGIN..MSG_RAW_MOUSE_END --> D[onMouseEvent]
    B -- other --> E[return KEEP_MESSAGE]
    C --> F[getActionKeyType / getKeyModState]
    F --> G{modStateRemoved? keyType==MK_NONE && KEY_UP}
    G -- yes --> H[onKeyModStateRemoved: clear stale key-mod states, fire UP transitions]
    G -- no --> I[onKeyPressed: match meta-map, set/clear key-mod state]
    D --> J{mouse message type}
    J -- BUTTON_DOWN --> K[record down position, clear double-click flag]
    J -- DOUBLE_CLICK --> L[set double-click flag]
    J -- BUTTON_UP --> M[insert click or double-click message]

Loading

_{Reviews (4): Last reviewed commit: "Replicate in Generals" | Re-trigger Greptile}

[RikuAnt]

Logically sound change. The focus is clearly to just relocate the code into new helper methods, but I would recommend some minor refactors as well.

[RikuAnt]

I don't have permission to resolve my own comments, so feel free to resolve them. Applies also for approval, so someone elses blessing is needed here. FYI @xezon

[xezon]

Replicated in Generals without conflicts