Dont add the brackets if the sample IO is for one IO instead of a bus#29
Merged
vlahtin merged 1 commit intoiofile-refactorfrom Dec 1, 2025
Merged
Dont add the brackets if the sample IO is for one IO instead of a bus#29vlahtin merged 1 commit intoiofile-refactorfrom
vlahtin merged 1 commit intoiofile-refactorfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
found a nice feature in spice as I happened to do something that I don't think has been done before.
The sample iotype did not work if the bus width was one (just e.g. <0> instead of <10:0>). This PR should fix it.
Please test if this breaks any case you have using sample IO types. @MiikkaMaki @sporrasm